SYSTEMS-16617 deprecation fixes#4
Merged
Merged
Conversation
Upgrade @actions/github 2.x -> 6.x and typescript 3.x -> 5.x. http-client v2+ drops url.parse, eliminating DEP0169 at runtime. Update src to use getOctokit() and client.rest.* API. Rebuild dist.
Drop yarn.lock, add package-lock.json. Add overrides to pin eslint-plugin-relay@1.8.0 (1.7.0 uses invalid semver peer dep that npm rejects). Update scripts and CLAUDE.md accordingly.
Bump jest+ts-jest 25→29, @types/jest 25→29, @types/node 14→24. Drop jest-circus (bundled in jest 27+). npm install now works without flags. ESLint 6 stays; overrides handle relay peer dep.
- eslint 6→8, eslint-plugin-github 3→5 (drops relay dep + overrides) - @typescript-eslint/parser+plugin 2→8 - eslint-plugin-jest 23→28, eslint-plugin-prettier 3→5, prettier 1→3 - Remove jest-circus (default in jest 27+), drop testRunner from jest.config.js - Simplify .eslintrc.json: removed dead rules (camelcase/class-name-casing/ generic-type-naming replaced by naming-convention, ban-ts-ignore→ban-ts-comment) and rules now covered by plugin:github/typescript extend - Drop overrides block (no longer needed without relay dep)
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Bump @actions/core 1.x→3.x and @actions/github 6.x→9.x; both now pull http-client@3-4 which resolves undici@6.25.0 (patched). Drop unused @octokit/rest devDep (carried 5 additional vulns). Update tsconfig to module/moduleResolution bundler + target es2022 for newer octokit types.
Workflow still referenced yarn after the npm migration in b9274dd, causing the dist check to fail with a mismatched bundle.
There was a problem hiding this comment.
Pull request overview
Updates this TypeScript GitHub Action to address deprecations by modernizing the build/tooling stack and migrating to the current @actions/github Octokit API surface, while aligning CI to an npm-based workflow.
Changes:
- Migrate from deprecated
GitHubconstructor usage togetOctokit()andclient.rest.*API calls. - Modernize TypeScript/Jest/ESLint configurations and upgrade key dependencies/tooling.
- Switch CI and the “all” script from Yarn-based commands to npm equivalents; add
CLAUDE.mdcontributor notes.
Reviewed changes
Copilot reviewed 5 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tsconfig.json |
Updates TS emit/resolution settings (target/module/moduleResolution) for newer toolchain. |
src/main.ts |
Replaces deprecated Octokit usage and hardens a couple of runtime edge cases (files nullable, non-Error throws). |
package.json |
Updates dependencies/devDependencies and converts the “all” script to npm. |
jest.config.js |
Removes explicit jest-circus runner setting (now default in modern Jest). |
CLAUDE.md |
Adds repo/action development and packaging guidance. |
.github/workflows/test.yml |
Converts CI install/build steps from Yarn to npm commands. |
.eslintrc.json |
Reworks ESLint base config to newer presets and reduces explicit configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
gplechuck
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.