This repository was archived by the owner on Feb 10, 2021. It is now read-only.
Implementation of wrong credentials exception#29
Merged
lnunes-daitan merged 6 commits intomasterfrom Jun 18, 2015
Merged
Conversation
There was a problem hiding this comment.
If 400 is returned, it means that the credentials are invalid not missing, isn't it?
Contributor
Author
There was a problem hiding this comment.
Only error 401 matters here. It refers to this case of error: {"category":"authorization","code":"access-denied","message":"The authenticated user does not have sufficient permissions to access this resource","details":[{"name":"requestMethod","value":"GET"},{"name":"remoteAddress","value":"127.0.0.1"},{"name":"requestPath","value":"/users/your_User_Id_here/account"}]}
There was a problem hiding this comment.
Ensure that if user provides any credential with white spaces, it will be removed on SDK.
Contributor
|
Regarded Leo's points, Approved. |
…a-bandwidth into missing_creds_exception
lnunes-daitan
added a commit
that referenced
this pull request
Jun 18, 2015
Implementation of wrong credentials exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On getInstance() and setCredentials, added a call to getAccountInfo to validate if set credentials are correct