This repository was archived by the owner on Feb 10, 2021. It is now read-only.
TDP-1204 Change finalize to close() so users can shutdown the client#44
Merged
mrmeyers99 merged 2 commits intomasterfrom Jul 16, 2018
Merged
TDP-1204 Change finalize to close() so users can shutdown the client#44mrmeyers99 merged 2 commits intomasterfrom
mrmeyers99 merged 2 commits intomasterfrom
Conversation
mrmeyers99
requested review from
dpereira-daitan,
jpinnix-bandwidth,
lnunes-daitan,
n-miles and
rmello-daitan
dpereira-daitan
approved these changes
Jul 13, 2018
n-miles
reviewed
Jul 13, 2018
n-miles
left a comment
n-miles
left a comment
There was a problem hiding this comment.
Do you not need to bump the POM version(s)?
Contributor
Author
|
No I don't need to. It's a snapshot version. I need to find out how the binary gets published though. |
n-miles
approved these changes
Jul 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.