VAPI-3239 fix: harden DTMF sending and always negotiate telephone-event codec#8
Merged
Merged
Conversation
Guard sendDtmf against unready or throwing RTCDTMFSender instances so one bad sender doesn't block others, and apply codec preferences unconditionally on audio tracks so telephone-event is always offered regardless of caller-provided codecPreferences. Also warn when an audio SDP offer lacks telephone-event, since DTMF can never negotiate for that session.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
smoghe-bw
changed the title
cguthrie-bw
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard sendDtmf against unready or throwing RTCDTMFSender instances so one bad sender doesn't block others, and apply codec preferences unconditionally on audio tracks so telephone-event is always offered regardless of caller-provided codecPreferences. Also warn when an audio SDP offer lacks telephone-event, since DTMF can never negotiate for that session.