Skip to content
This repository was archived by the owner on Sep 4, 2020. It is now read-only.

v6.2.1#319

Merged
mzarandona-bw merged 3 commits intomasterfrom
v6.2.1
Nov 12, 2019
Merged

v6.2.1#319
mzarandona-bw merged 3 commits intomasterfrom
v6.2.1

Conversation

@mzarandona-bw
Copy link
Copy Markdown
Contributor

@mzarandona-bw mzarandona-bw commented Nov 12, 2019

PR Checklist

Check these before submitting your pull request:

  • Visual and behavioral components are separated
  • Exported components are documented with examples
  • Props have JSDoc comments
  • All relevant visual sub-components can be overridden via props
  • Any extra props are spread into the outermost rendered element

Breaking Changes

  • Describe all breaking changes here

Changes to Existing Components

  • Describe meaningful changes to existing components here

New Visual Components

  • List and describe any new visual components (styled-component primitives) here. Visual components which are sub-components of exported components must be contained in a /styles directory adjacent to their super-component

New Behavioral Components

  • List and describe behavioral components here. Behavioral components must have no associated styling. If styling is necessary, refactor styled elements into visual components and ensure they can be overridden via props.

@mzarandona-bw mzarandona-bw self-assigned this Nov 12, 2019
tbowen-bw
tbowen-bw approved these changes Nov 12, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@tbowen-bw tbowen-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍕

@mzarandona-bw mzarandona-bw merged commit 557aac5 into master Nov 12, 2019
@mzarandona-bw mzarandona-bw deleted the v6.2.1 branch November 12, 2019 18:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zacklitzsinger zacklitzsinger Awaiting requested review from zacklitzsinger

@denysYefremov denysYefremov Awaiting requested review from denysYefremov

@jfontanez-bw jfontanez-bw Awaiting requested review from jfontanez-bw

3 more reviewers

@SmithPR SmithPR SmithPR approved these changes

@tbowen-bw tbowen-bw tbowen-bw approved these changes

@gforrest-bw gforrest-bw gforrest-bw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mzarandona-bw mzarandona-bw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mzarandona-bw @SmithPR @tbowen-bw @gforrest-bw