bfelf_loader/test: compile fix for test #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes error compiling:
/home/chris/git/hypervisor/bfelf_loader/test/test_loader_relocate.cpp: In member function ‘void bfelf_loader_ut::test_bfelf_loader_relocate_uninitialized_files()’:
/home/chris/git/hypervisor/bfelf_loader/test/test_loader_relocate.cpp:56:63: error: no match for ‘operator=’ (operand types are ‘std::shared_ptr<char>’ and ‘std::remove_reference<std::unique_ptr<char []>&>::type {aka std::unique_ptr<char []>}’)
m_dummy_misc_exec = std::move(std::get<0>(dummy_misc_pair));
...
Convert m_dummy_misc_exec and m_dummy_code_exec from:
- shared_ptr to unique_ptr
- from char to char[].
On a side note, how is this not caught by automated CI build/test?
Signed-off-by: Chris Patterson <pattersonc@ainfosec.com>
Contributor
Author
|
Thanks to @brendank310 for pointing out the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes error compiling:
/home/chris/git/hypervisor/bfelf_loader/test/test_loader_relocate.cpp: In member function ‘void bfelf_loader_ut::test_bfelf_loader_relocate_uninitialized_files()’:
/home/chris/git/hypervisor/bfelf_loader/test/test_loader_relocate.cpp:56:63: error: no match for ‘operator=’ (operand types are ‘std::shared_ptr’ and ‘std::remove_reference<std::unique_ptr<char []>&>::type {aka std::unique_ptr<char []>}’)
m_dummy_misc_exec = std::move(std::get<0>(dummy_misc_pair));
...
Convert m_dummy_misc_exec and m_dummy_code_exec from:
On a side note, how is this not caught by automated CI build/test?
Signed-off-by: Chris Patterson pattersonc@ainfosec.com