Fixed issue when with several monitors #2
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
I noticed an issue where the snow effect doesn’t work correctly on the secondary screen.
Issues
Reason
The shader was working with each screen separately, and the coordinates of the snowflakes are local to each screen. Meanwhile,
Uniforms.windowRectwhich is send inupdateSnowflakeshas global coordinates for all combined screens.Solution
To fix this, I added a conversion of the window coordinates from global to local. So I've added the calculation of the global 'united' display and pass it to each screens' renderer with the origin of each screen, so it can calculate local coordinate of point in global coordinate system.