fn:function-lookup: find functions from all modules of the executing query#2644
Merged
ChristianGruen merged 1 commit intoBaseXdb:mainfrom Apr 21, 2026
Merged
fn:function-lookup: find functions from all modules of the executing query#2644ChristianGruen merged 1 commit intoBaseXdb:mainfrom
fn:function-lookup: find functions from all modules of the executing query#2644ChristianGruen merged 1 commit intoBaseXdb:mainfrom
Conversation
GuntherRademacher
changed the title
fn:function-lookup: find functions from all modules of the executing query
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before #2554,
fn:function-lookupcould find any user-defined function declared in the executing query. That PR reorganized static functions by declaring module and introduced a visibility check based onsc.imports, which restrictedfn:function-lookupto only functions statically visible at the call site.The spec requires functions to be accessible if they are statically visible at the point where
fn:function-lookupis called, but it also allows access to functions that are present in the dynamic context, where the actual set of those functions is implementation-defined.The changes here restore the pre-#2554 behavior by passing a
useDynamicContextflag throughStaticFuncs.get()which causes thesc.importscheck to be skipped, so any non-private user-defined function in the executing query is reachable viafn:function-lookup, regardless of which module issues the call.