Skip reserved-function-name check for URIQualifiedLiteral#2681
Merged
ChristianGruen merged 2 commits intoMay 27, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The XQuery spec, since 1.0, contains a constraint named
reserved-function-nameswith a formulation like this or similar:The current implementation in BaseX focuses on "unprefixed" and thus tests the absence of a prefix. This may result in a URIQualifiedName being rejected, if its local name is in the list of reserved names.
I do not consider this as correct. The motivation behind the constraint is the ambiguity that arises when a plain name is used. For a URIQualifiedName, this ambiguity does not exist - the
Q{uri}local-nameform unambiguously stands for a QName.I thus propose to make the implementation focus on the spec's wording "function names spelled the same way as language keywords", and treating URIQualifiedNames as outside the constraint's scope.
This is implemented in this PR.