Fix IndexOutOfBoundsException for non-existing groups in fn:replace#2698
Merged
Conversation
Member
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported by Amanda Galtman on basex-talk, an
IndexOutOfBoundsExceptioncan occur when the replacement string contains a reference to a non-existing capture group that is preceded by a backslash, e.g.The issue is caused by
FnReplace.item, which only examines the single character preceding a dollar sign. If that character is a backslash, the dollar sign is assumed to be escaped, and the replacement string is subsequently passed toMatcher.replaceAll.The fix is to count the number of consecutive preceding backslashes. The dollar sign is escaped only if that count is odd.