Fixes on chunks sync successful out of range

[beastoin]

Summary by Entelligence.AI

• Bug Fix: Improved the logic in the Wals service to accurately update the status of Wals and notify subscribers. This fix enhances the reliability of status updates, providing users with more accurate and timely information about their Wals.

[github-actions]

Entelligence.AI

Walkthrough

The changeset primarily focuses on enhancing the loop logic in the wals.dart file. The update ensures accurate status updates for Wals and proper notification to subscribers. A new variable, wal, has been introduced to store the current Wal object, improving code readability and maintainability.

Changes

File	Summary
app/lib/services/wals.dart	Updated loop logic for correct status updates of Wals and subscriber notifications. Introduced a wal variable for storing the current Wal object, enhancing clarity.

"In the realm of code, where logic is king,
An update arrives, with improvements it brings.
No more confusion, no more stall,
Clear as crystal, stands the wal.
Subscribers rejoice, they're in the know,
As the status of Wals, correctly show.
So here's to progress, however small,
In the grand scheme of things, it benefits all." 🎉🚀

---

Uplevel your code reviews with Entelligence.AI Pro

Entelligence.AI Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, Entelligence.AI Pro is free for open source projects.

[github-actions]

Entelligence.AI

Commits

Files that changed from the base of the PR and between 8f60719 and fe3e0ff commits.

Files selected (1)

• app/lib/services/wals.dart (1)

Review comments generated (2)

• Review: 2
• LGTM: 0

---

Tips

Chat with Entelligence.AI Bot (@Entelligence.AI)

• Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
• Invite the bot into a review comment chain by tagging @Entelligence.AI in a reply.

Code suggestions

• The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
• You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

• Add @Entelligence.AI: ignore anywhere in the PR description to pause further reviews from the bot.

[github-actions]

Entelligence.AI

The new loop logic seems to be correct, but it's not clear why the wal variable is introduced. It seems to be used only once in the onWalSynced method call. If there's no other use for this variable, it might be better to directly use wals[j] in the onWalSynced method call to avoid unnecessary variable assignment.

-         var wal = wals[j];
-         wals[j].status = WalStatus.synced; // ref to _wals[]
+         wals[j].status = WalStatus.synced;
  
          // Send
          for (var sub in _subscriptions.values) {
-           sub.onWalSynced(wal);
+           sub.onWalSynced(wals[j]);
          }

[github-actions]

Entelligence.AI

There is a potential issue with the way subscriptions are handled. If a subscription is removed during the iteration of _subscriptions.values, it could lead to a ConcurrentModificationError. Consider making a copy of the values before iterating over them.

-          for (var sub in _subscriptions.values) {
+          for (var sub in List.from(_subscriptions.values)) {
            sub.onWalSynced(wals[j]);
          }