Skip to content

Decrease modal timeout to 10m#1038

Merged
beastoin merged 1 commit intomainfrom
pbbrr_modal_10m
Oct 11, 2024
Merged

Decrease modal timeout to 10m#1038
beastoin merged 1 commit intomainfrom
pbbrr_modal_10m

Conversation

@beastoin
Copy link
Copy Markdown
Collaborator

@beastoin beastoin commented Oct 11, 2024

Summary by CodeRabbit

  • New Features

    • Enhanced management of WebSocket sessions for improved audio processing.
  • Improvements

    • Reduced timeout settings for API functions and WebSocket sessions to optimize performance and responsiveness.

These changes aim to provide a more efficient user experience during audio transcription tasks.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 11, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes involve adjustments to timeout settings across several files in the backend of the application. Specifically, the timeout for the api function in main.py has been reduced from 2100 seconds to 600 seconds. Additionally, the WebSocket session timeouts in both transcribe.py and transcribe_v2.py have been decreased from 1920 seconds to 420 seconds. Modifications to functions related to audio processing and WebSocket management have been implemented to accommodate these new timeout values.

Changes

File Path Change Summary
backend/main.py Timeout for api function updated from 2100 seconds to 600 seconds.
backend/routers/transcribe.py WebSocket session timeout reduced from 1920 seconds to 420 seconds; modifications to _websocket_util, stream_transcript, and receive_audio functions for audio management.
backend/routers/transcribe_v2.py WebSocket session timeout reduced from 1920 seconds to 420 seconds; updates to send_heartbeat function for session management.

Poem

In the garden where we play,
Timers tick, but not all day!
With hops and jumps, we’ll dance around,
Shorter waits, new joys abound!
So gather 'round, both big and small,
For changes here will please us all! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@beastoin beastoin merged commit 2c36bbb into main Oct 11, 2024
@beastoin beastoin deleted the pbbrr_modal_10m branch October 11, 2024 04:52
@beastoin beastoin changed the title Increase modal timeout to 10m Decrease modal timeout to 10m Oct 11, 2024
Glucksberg pushed a commit to Glucksberg/omi-local that referenced this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant