Catch device connection exception; force close ws on dirty state

[beastoin]

Summary by CodeRabbit

• New Features

  • Introduced a new exception class for improved error handling related to device connections.
  • Enhanced audio transcription service with refined WebSocket handling and a new function for speech detection.

• Bug Fixes

  • Improved error handling for device connection issues and WebSocket connections, ensuring more descriptive error reporting.

• Documentation

  • Updated method signatures for clarity and improved readability.

• Refactor

  • Streamlined connection handling logic in device services for better maintainability.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several modifications across multiple files to enhance device connection handling and WebSocket audio processing. Key changes include renaming and streamlining methods in the DeviceProvider, improved error handling in the DeviceService, and the introduction of a new exception class, DeviceConnectionException, for more specific error reporting. Additionally, the WebSocket handling in transcribe.py and transcribe_v2.py has been refined to improve robustness and functionality in audio transcription services.

Changes

File Path	Change Summary
app/lib/providers/device_provider.dart	- Renamed onDeviceReconnected to _onDeviceConnected. - Updated onDeviceConnectionStateChanged to call _onDeviceConnected. - Modified onDevices to utilize the new method.
app/lib/services/devices.dart	- Added error handling in ensureConnection with a try-catch block for DeviceConnectionException. - Used null-aware assignment for _firstConnectedAt.
app/lib/services/devices/device_connection.dart	- Introduced DeviceConnectionException for specific connection errors. - Updated connect method to throw this new exception. - Improved method signatures for readability.
app/lib/services/devices/friend_connection.dart	- Replaced generic Exception with DeviceConnectionException for BLE service errors. - Updated logging for service absence to reflect correct service name.
backend/routers/transcribe.py	- Enhanced WebSocket handling with error handling for connections. - Updated stream_transcript for accurate segment alignment. - Improved audio data handling in receive_audio.
backend/routers/transcribe_v2.py	- Added error handling for WebSocket connections and introduced _has_speech function. - Improved memory creation handling with a timeout mechanism. - Updated stream_transcript for timing accuracy.

Possibly related PRs

• Fix Battery stays -1% if device is automatically connected for first time #1040: The changes in the DeviceProvider class regarding the onDeviceReconnected method are directly related to the modifications made in the main PR, which also involves renaming and streamlining connection handling methods in the same class.
• Instabug reported fixes #1043: The updates to the FriendDeviceConnection class include error handling related to device connections, which aligns with the main PR's focus on improving device connection event handling in the DeviceProvider class.

🐇 In the meadow where devices play,
I hop and skip, it's a bright new day!
With connections strong and errors few,
Our code is fresh, and so are you!
We dance with bytes, in a joyful trance,
Celebrating changes, let's take a chance! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.