Skip to content

Fix errors on query plugins collection by multi field#1300

Merged
beastoin merged 1 commit intomainfrom
uprtm_fix_plugin_query
Nov 13, 2024
Merged

Fix errors on query plugins collection by multi field#1300
beastoin merged 1 commit intomainfrom
uprtm_fix_plugin_query

Conversation

@beastoin
Copy link
Copy Markdown
Collaborator

Error:

/opt/homebrew/lib/python3.11/site-packages/google/cloud/firestore_v1/base_collection.py:300: UserWarning: Detected filter using positional arguments. Prefer using the 'filter' keyword argument instead.
  return query.where(field_path, op_string, value)
/private/tmp/x.py:41: UserWarning: Detected filter using positional arguments. Prefer using the 'filter' keyword argument instead.
  unapproved = db.collection('plugins_data').where('approved', '==', False).where('uid', '==', uid).stream()
Traceback (most recent call last):
  File "/private/tmp/x.py", line 70, in <module>
    print(get_plugins_data_from_db("eLCxTds6QyUAHraZug48i8ZlGL23"))
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/private/tmp/x.py", line 58, in get_plugins_data_from_db
    public_data = get_public_plugins_db(uid)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/private/tmp/x.py", line 42, in get_public_plugins_db
    data.extend([doc.to_dict() for doc in unapproved])
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/private/tmp/x.py", line 42, in <listcomp>
    data.extend([doc.to_dict() for doc in unapproved])
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/google/cloud/firestore_v1/query.py", line 357, in _make_stream
    response_iterator, expected_prefix = self._get_stream_iterator(
                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/google/cloud/firestore_v1/query.py", line 223, in _get_stream_iterator
    request, expected_prefix, kwargs = self._prep_stream(
                                       ^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/google/cloud/firestore_v1/base_query.py", line 1027, in _prep_stream
    "structured_query": self._to_protobuf(),
                        ^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/google/cloud/firestore_v1/base_query.py", line 968, in _to_protobuf
    "where": self._filters_pb(),
             ^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/google/cloud/firestore_v1/base_query.py", line 847, in _filters_pb
    composite_filter.filters.append(_filter_pb(filter_))
TypeError: Parameter to MergeFrom() must be instance of same class: expected google.firestore.v1.StructuredQuery.Filter got Filter.

@beastoin beastoin marked this pull request as ready for review November 13, 2024 04:55
@beastoin beastoin merged commit a14fcfc into main Nov 13, 2024
@beastoin beastoin deleted the uprtm_fix_plugin_query branch November 13, 2024 04:56
Glucksberg pushed a commit to Glucksberg/omi-local that referenced this pull request Apr 28, 2026
…1300)

Error:
```
/opt/homebrew/lib/python3.11/site-packages/google/cloud/firestore_v1/base_collection.py:300: UserWarning: Detected filter using positional arguments. Prefer using the 'filter' keyword argument instead.
  return query.where(field_path, op_string, value)
/private/tmp/x.py:41: UserWarning: Detected filter using positional arguments. Prefer using the 'filter' keyword argument instead.
  unapproved = db.collection('plugins_data').where('approved', '==', False).where('uid', '==', uid).stream()
Traceback (most recent call last):
  File "/private/tmp/x.py", line 70, in <module>
    print(get_plugins_data_from_db("eLCxTds6QyUAHraZug48i8ZlGL23"))
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/private/tmp/x.py", line 58, in get_plugins_data_from_db
    public_data = get_public_plugins_db(uid)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/private/tmp/x.py", line 42, in get_public_plugins_db
    data.extend([doc.to_dict() for doc in unapproved])
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/private/tmp/x.py", line 42, in <listcomp>
    data.extend([doc.to_dict() for doc in unapproved])
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/google/cloud/firestore_v1/query.py", line 357, in _make_stream
    response_iterator, expected_prefix = self._get_stream_iterator(
                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/google/cloud/firestore_v1/query.py", line 223, in _get_stream_iterator
    request, expected_prefix, kwargs = self._prep_stream(
                                       ^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/google/cloud/firestore_v1/base_query.py", line 1027, in _prep_stream
    "structured_query": self._to_protobuf(),
                        ^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/google/cloud/firestore_v1/base_query.py", line 968, in _to_protobuf
    "where": self._filters_pb(),
             ^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/google/cloud/firestore_v1/base_query.py", line 847, in _filters_pb
    composite_filter.filters.append(_filter_pb(filter_))
TypeError: Parameter to MergeFrom() must be instance of same class: expected google.firestore.v1.StructuredQuery.Filter got Filter.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant