Skip to content

Add and Enable Real-time Audio Bytes to Trigger Events#1395

Merged
beastoin merged 9 commits intomainfrom
audio-trigger-event
Feb 1, 2025
Merged

Add and Enable Real-time Audio Bytes to Trigger Events#1395
beastoin merged 9 commits intomainfrom
audio-trigger-event

Conversation

@mdmohsin7
Copy link
Copy Markdown
Member

@mdmohsin7 mdmohsin7 commented Nov 23, 2024

Closes #1336 #1727

Add the ability for apps to receive real-time audio bytes. This opens up the possibility of building a lot more applications utilising real-time audio.

  • Add audio bytes trigger
  • Check if audio apps enabled before pushing
  • Set default time duration for audio bytes to 5 for all apps
Screenshot 2025-01-26 at 5 42 10 PM

@beastoin
Copy link
Copy Markdown
Collaborator

this is a cool feature!

btw bro, do you think ppl would like to allow their voice go through another app but not Omi ?

allow the creator define the duration?

yes, min 5s

@mdmohsin7
Copy link
Copy Markdown
Member Author

mdmohsin7 commented Nov 26, 2024

I think there are use cases that omi does not cater to (for now). This would allow creators to create apps to store recordings in gdrive/icloud, sentiment analysis and other use cases which we aren't aware of maybe?

btw bro, do you think ppl would like to allow their voice go through another app but not Omi ?

I guess it will depend on the app, if they want to use it and it isn't privacy invasive, then they'll use it

@beastoin
Copy link
Copy Markdown
Collaborator

so, let's do a small survey(as a simple decision making framework), if we have 6 votes for this feature (in any platforms) then we go with it, is it okay?

about the implementation:
1/ you should check if the user installed at least 01 audio-byte triggered app or not, before setting up the pusher's audio consume
2/ at pusher, your implement is not support for the different thresholds yet e.g, users installed multiple audio-byte triggered app and they have different threshold to received audio bytes.

so so complicated, right ? so let finish the survey first :)

@mdmohsin7
Copy link
Copy Markdown
Member Author

Yes I did not move forward with continuing the implementation because I too wasn't sure if we really should add this, hence 1/ and 2/ are not done. As you mentioned, let's go with a survey and then decide whether we should really add this or not

I've progressed a lot, now this stuff doesn't seem to be very complicated to me XD (thanks to you and Joan)

@beastoin beastoin marked this pull request as draft November 28, 2024 03:54
@mdmohsin7
Copy link
Copy Markdown
Member Author

@mdmohsin7 mdmohsin7 marked this pull request as ready for review January 26, 2025 12:22
@mdmohsin7
Copy link
Copy Markdown
Member Author

Review pls @beastoin

@beastoin
Copy link
Copy Markdown
Collaborator

@mdmohsin7
Copy link
Copy Markdown
Member Author

1/ I don't think we need to, because at the time of testing in dev environment it never asked me to

@beastoin

@smian1 smian1 linked an issue Feb 1, 2025 that may be closed by this pull request
@beastoin beastoin merged commit a59e55f into main Feb 1, 2025
@beastoin beastoin deleted the audio-trigger-event branch February 1, 2025 23:11
@beastoin
Copy link
Copy Markdown
Collaborator

beastoin commented Feb 1, 2025

lgtm @mdmohsin7 🚀

@beastoin
Copy link
Copy Markdown
Collaborator

beastoin commented Feb 3, 2025

Production change logs

  1. Feature on prod 🚀

@mdmohsin7 pls check ~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add and Enable Real-time Audio Bytes to Trigger Events Add Real-Time Audio Bytes Trigger Event

2 participants