Add and Enable Real-time Audio Bytes to Trigger Events#1395
Conversation
|
this is a cool feature! btw bro, do you think ppl would like to allow their voice go through another app but not Omi ?
yes, min 5s |
|
I think there are use cases that omi does not cater to (for now). This would allow creators to create apps to store recordings in gdrive/icloud, sentiment analysis and other use cases which we aren't aware of maybe?
I guess it will depend on the app, if they want to use it and it isn't privacy invasive, then they'll use it |
|
so, let's do a small survey(as a simple decision making framework), if we have 6 votes for this feature (in any platforms) then we go with it, is it okay? about the implementation: so so complicated, right ? so let finish the survey first :) |
|
Yes I did not move forward with continuing the implementation because I too wasn't sure if we really should add this, hence 1/ and 2/ are not done. As you mentioned, let's go with a survey and then decide whether we should really add this or not I've progressed a lot, now this stuff doesn't seem to be very complicated to me XD (thanks to you and Joan) |
|
Review pls @beastoin |
|
1/ do we need to create new firestore index https://github.com/BasedHardware/omi/pull/1395/files#diff-e9334601001806a62e30da99b753c713c2c20213a661ced0a88542e66e39697eR45 @mdmohsin7 overall, it's good. |
|
1/ I don't think we need to, because at the time of testing in dev environment it never asked me to |
|
lgtm @mdmohsin7 🚀 |
Production change logs
@mdmohsin7 pls check ~ |
Closes #1336 #1727
Add the ability for apps to receive real-time audio bytes. This opens up the possibility of building a lot more applications utilising real-time audio.