Skip to content

UX stuff fixes #1610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdmohsin7 merged 3 commits into from
Dec 29, 2024
Merged

UX stuff fixes #1610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f57f45
reset search on empty query
mdmohsin7 Dec 29, 2024
40ffa39
apps heading padding fix
mdmohsin7 Dec 29, 2024
a790151
search focussed border color fix
mdmohsin7 Dec 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions app/lib/pages/conversations/widgets/search_widget.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class _SearchWidgetState extends State<SearchWidget> {
crossAxisAlignment: CrossAxisAlignment.center,
children: [
Container(
padding: const EdgeInsets.fromLTRB(16, 16, 2, 0),
padding: const EdgeInsets.fromLTRB(16, 16, 2, 10),
width: MediaQuery.sizeOf(context).width * 0.85,
child: TextFormField(
controller: searchController,
Expand All @@ -50,7 +50,15 @@ class _SearchWidgetState extends State<SearchWidget> {
// fillColor: Colors.grey[900],
border: OutlineInputBorder(
borderRadius: BorderRadius.circular(12),
borderSide: BorderSide(color: Colors.grey.shade900, width: 0.5),
borderSide: BorderSide(color: Colors.grey.shade800, width: 0.5),
),
focusedBorder: OutlineInputBorder(
borderRadius: BorderRadius.circular(12),
borderSide: BorderSide(color: Colors.grey.shade500, width: 0.5),
),
enabledBorder: OutlineInputBorder(
borderRadius: BorderRadius.circular(12),
borderSide: BorderSide(color: Colors.grey.shade500, width: 0.5),
),
prefixIcon: Icon(
Icons.search,
Expand Down
5 changes: 4 additions & 1 deletion app/lib/pages/home/page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,10 @@ class _HomePageState extends State<HomePage> with WidgetsBindingObserver, Ticker
controller: _controller,
);
} else if (provider.selectedIndex == 2) {
return const Text('Apps', style: TextStyle(color: Colors.white, fontSize: 18));
return Padding(
padding: EdgeInsets.only(right: MediaQuery.sizeOf(context).width * 0.16),
child: const Text('Apps', style: TextStyle(color: Colors.white, fontSize: 18)),
);
} else {
return Flexible(
child: Row(
Expand Down
5 changes: 5 additions & 0 deletions app/lib/providers/conversation_provider.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,11 @@ class ConversationProvider extends ChangeNotifier implements IWalServiceListener
}

Future<void> searchConversations(String query) async {
if (query.isEmpty) {
searchedConversations = conversations;
groupSearchConvosByDate();
return;
}
if (query == previousQuery) {
return;
}
Expand Down