chore: add timeout for api#1638
Conversation
|
gm 1/ can we customize the timeout for specific routes ? e.g. GET request - 30s, POST/PATCH/DELETE 5m 2/ does the timeout work for both sync and async route func ? 3/ double checking the app to ensure they don't need the full transcript segments via /memories api. then do some necessary changes on the app, backward compatible must. 4/ snake case pls 5/ > await getConversations(limit: 10000, offset: 0, segmentLimit: 10000); // 10k for now |
|
1/ updated, can custom with specific routes 2/ i found docs of fastapi that fastapi automatically wraps synchronous route functions in asyncio, so its work for both sync and async route 3/ updated 4/ updated 5/ i'll have another MR to solve this issue @beastoin pls help me to review again |
|
1/ ok |
2317444 to
ac328e5
Compare
|
3/ updated. @beastoin pls help me review |
|
3/ to reduce the risk of break changes lets discard the limit_segment logic. |
|
3/ discarded all logic about segment limit |
|
3/ ✅ ok @nquang29 last commit pls sir. |
|
7/ i have discarded it |
|
7/ ✅ ok lgtm @nquang29 / congratulation 🚀 |

No description provided.