Skip to content

Stripe connect (payments rework)#1746

Merged
beastoin merged 26 commits intomainfrom
stripe-connect
Feb 9, 2025
Merged

Stripe connect (payments rework)#1746
beastoin merged 26 commits intomainfrom
stripe-connect

Conversation

@mdmohsin7
Copy link
Copy Markdown
Member

@mdmohsin7 mdmohsin7 commented Feb 2, 2025

closes #1597

  • Setup stripe connect onboarding flow on backend and app
  • Paypal details flow on backend and app
  • Link app payments to connected accounts through destination charges
  • Handle all onboarding flow cases in app
  • Separate payments page like Shopify
  • Cleanup and test all cases
  • Fix minor issues

Points to note:

  • New payment links will have to be created for current paid apps to add destination charge
  • I set transfer type to destination charge instead of direct charge (in case of direct charge, the user will need to provide a lot more stuff for identity verification). In destination charge we will have to pay the stripe fees (hence I set the marketplace fee as 10% to cover the stripe fees), whereas in direct charge the stripe fee is deducted from the amount (alongside the marketplace fee which we define) and then the remaining amount is transferred to connected account.
  • With this PR, it will be mandatory to connect stripe to be able to make paid apps
  • We (Omi Team) will be bearing the stripe fees and there will be no fee for creators
ScreenRecording_02-08-2025.18-33-51_1.1.mp4

@mdmohsin7 mdmohsin7 marked this pull request as ready for review February 3, 2025 16:22
@beastoin
Copy link
Copy Markdown
Collaborator

beastoin commented Feb 5, 2025

1/ can we set the fee to 0% ? we need to attract more apps creators.

hence I set the marketplace fee as 10% to cover the stripe fees

2/ can we set it as optional ? you know that Stripe is not support some countries, so that, we can maximize the chance developers create paid apps.

With this PR, it will be mandatory to connect stripe to be able to make paid apps

ref: if the person cannot use stripe, just add a comment there that they can receive via Paypal manually (monthly) on the same email

3/ could you record a more detail demo video ? e.g. how to connect to stripe, start from the omi apps screen

@mdmohsin7

@mdmohsin7
Copy link
Copy Markdown
Member Author

mdmohsin7 commented Feb 5, 2025

1/ Yes we can, then we will have to bear the stripe costs
2/ Yes can do, we need to collect paypal or other information then. Should I restore part of that functionality from #1492 ?

@beastoin

@mdmohsin7
Copy link
Copy Markdown
Member Author

3/

ScreenRecording_02-05-2025.13-10-37_1.mp4
Screenshot 2025-02-05 at 1 14 44 PM Screenshot 2025-02-05 at 1 14 53 PM

@beastoin demo

@beastoin
Copy link
Copy Markdown
Collaborator

beastoin commented Feb 6, 2025

1/ it's okay, please set the fee to 0%
2/ you can copy the necessary parts but please keep it minimal.
3/ ✅ okay
4/ could you change thePayment Method to Payments, put it on new section named CREATORS (above the PREFERENCES),. you could also try the similar UI to the Shopify app.
IMG_982723BEAC2D-1 2

what do you think @mdmohsin7

@mdmohsin7
Copy link
Copy Markdown
Member Author

mdmohsin7 commented Feb 7, 2025

Although the functionality is ready, some cleanup has to be done before it can be merged

@mdmohsin7
Copy link
Copy Markdown
Member Author

Pls check @beastoin, I've also updated the video in the first comment to reflect the complete flows

@beastoin
Copy link
Copy Markdown
Collaborator

beastoin commented Feb 9, 2025

1/ ✅
2/ ✅
4/ ✅
5/ change POST stripe/create-connect-account -> POST stripe/connect-accounts

@mdmohsin7 last commit pls sir

@mdmohsin7
Copy link
Copy Markdown
Member Author

5/ done sir @beastoin

@beastoin
Copy link
Copy Markdown
Collaborator

beastoin commented Feb 9, 2025

5/ ✅

lgmt @mdmohsin7

@beastoin beastoin merged commit d345e61 into main Feb 9, 2025
@beastoin beastoin deleted the stripe-connect branch February 9, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Payments rework

2 participants