Personas memories fix

[mdmohsin7]

• 30s timeout for X api calls
• add try catch for sync_update_persona_prompt
• update the persona prompts async in a separate thread without disturbing the process_memory

[beastoin]

1/ from my experience, this code block is the cause of websocket connection drop (/listen API). do you experience the same ? https://github.com/BasedHardware/omi/pull/1917/files#diff-e518096e8d0948a411d3035bacafc371d1a8600659b7b7f6ea667f73b2231dc4L195-R203

@mdmohsin7

[mdmohsin7]

1/ I did not had issues when I was testing locally (with 30s timeout). I'll test it a bit more and maybe will move it to make it independent so no other function should be dependent on it

@beastoin

[beastoin]

1/ please do a small research. how does the thread impact to the python application ?

@mdmohsin7

[beastoin]

@nquang29 babe, could you help Mohsin a bit with researching, why this code of block drop the WS connection sometime ?

[mdmohsin7]

1/ sure will do, just occupied with somewhat more support tickets haha. And Quang has already been a lot helpful to me, and some more insights from him will only help me more

[nquang29]

i think this issue come from join(), calling .join() in the main thread blocks execution until all threads finish.
If the WS is running on the same thread, it might time out or get interrupted while waiting for threads to complete.
I found docs about join() here: https://stackoverflow.com/questions/15085348/what-is-the-use-of-join-in-threading

[beastoin]

nice. can you verify it ? i mean reproducing the issue and solving it. @nquang29 @mdmohsin7

[mdmohsin7]

The old code that was there initially indeed blocks the main thread. But the code introduced in this PR does not. Because we are starting the personas updation in a separate thread without joining it to main thread

threading.Thread(target=_update_personas_async, args=(uid,)).start()

This won't block the main thread. This separate thread will be blocked until all the sub threads in it are complete

Below print statements for reference:

Print statements in code:

[beastoin]

ok cool. lgtm @mdmohsin7 🚀