Skip to content

App persona fixes #1949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beastoin merged 4 commits into from
Mar 9, 2025
Merged

App persona fixes #1949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
91cb888
add user agent for linkedin profiles and improve error widget positio…
mdmohsin7 Mar 4, 2025
6cf2fc6
handle app author names with special chars
mdmohsin7 Mar 4, 2025
2042e3a
remove unused persona widgets and cleanup
mdmohsin7 Mar 6, 2025
1bc0f0e
Merge branch 'main' into app-persona-fixes
mdmohsin7 Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/lib/pages/apps/app_detail/app_detail.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ class _AppDetailPageState extends State<AppDetailPage> {
),
const SizedBox(height: 4),
Text(
app.author,
app.author.decodeString,
style: const TextStyle(color: Colors.grey, fontSize: 14),
),
],
Expand Down
13 changes: 12 additions & 1 deletion app/lib/pages/apps/list_item.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ class AppListItem extends StatelessWidget {
children: [
CachedNetworkImage(
imageUrl: app.getImageUrl(),
httpHeaders: const {
"User-Agent":
"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.124 Safari/537.36",
},
imageBuilder: (context, imageProvider) => Container(
width: 48,
height: 48,
Expand All @@ -50,7 +54,14 @@ class AppListItem extends StatelessWidget {
valueColor: AlwaysStoppedAnimation<Color>(Colors.white),
),
),
errorWidget: (context, url, error) => const Icon(Icons.error),
errorWidget: (context, url, error) => const SizedBox(
width: 48,
height: 48,
child: Icon(
Icons.error,
color: Colors.white,
),
),
),
const SizedBox(width: 14),
Expanded(
Expand Down
2 changes: 0 additions & 2 deletions app/lib/pages/apps/widgets/create_options_sheet.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import 'package:flutter/material.dart';
import 'package:friend_private/pages/apps/add_app.dart';
import 'package:friend_private/pages/persona/add_persona.dart';
import 'package:friend_private/pages/persona/persona_profile.dart';
import 'package:friend_private/pages/persona/persona_provider.dart';
import 'package:friend_private/providers/home_provider.dart';
import 'package:provider/provider.dart';
Expand Down
3 changes: 0 additions & 3 deletions app/lib/pages/apps/widgets/show_app_options_sheet.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
import 'package:flutter/material.dart';
import 'package:friend_private/backend/schema/app.dart';
import 'package:friend_private/pages/apps/update_app.dart';
import 'package:friend_private/pages/persona/persona_profile.dart';
import 'package:friend_private/pages/persona/persona_provider.dart';
import 'package:friend_private/providers/home_provider.dart';
import 'package:provider/provider.dart';
import 'package:friend_private/pages/persona/update_persona.dart';
import 'package:friend_private/providers/app_provider.dart';
import 'package:friend_private/utils/other/temp.dart';
import 'package:friend_private/widgets/dialog.dart';
import 'package:provider/provider.dart';

class ShowAppOptionsSheet extends StatelessWidget {
final App app;
Expand Down
1 change: 0 additions & 1 deletion app/lib/pages/capture/widgets/widgets.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import 'package:friend_private/pages/speech_profile/page.dart';
import 'package:friend_private/providers/capture_provider.dart';
import 'package:friend_private/providers/device_provider.dart';
import 'package:friend_private/providers/home_provider.dart';
import 'package:friend_private/utils/analytics/intercom.dart';
import 'package:friend_private/utils/analytics/mixpanel.dart';
import 'package:friend_private/utils/enums.dart';
import 'package:friend_private/utils/other/temp.dart';
Expand Down
4 changes: 2 additions & 2 deletions app/lib/pages/chat/clone_chat_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import 'package:flutter/material.dart';
import 'package:flutter/scheduler.dart';
import 'package:flutter_svg/flutter_svg.dart';
import 'package:friend_private/utils/analytics/mixpanel.dart';
import 'package:friend_private/gen/assets.gen.dart';
import 'package:friend_private/backend/preferences.dart';
import 'package:friend_private/backend/schema/app.dart';
import 'package:friend_private/pages/chat/page.dart';
Expand Down Expand Up @@ -70,7 +70,7 @@ class CloneChatPageState extends State<CloneChatPage> {
IconButton(
padding: const EdgeInsets.all(8.0),
icon: SvgPicture.asset(
'assets/images/ic_persona_profile.svg',
Assets.images.icPersonaProfile.path,
width: 28,
height: 28,
),
Expand Down
1 change: 0 additions & 1 deletion app/lib/pages/conversations/conversations_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import 'package:flutter/material.dart';
import 'package:friend_private/backend/schema/conversation.dart';
import 'package:friend_private/pages/capture/widgets/widgets.dart';
import 'package:friend_private/pages/conversations/widgets/local_sync.dart';
import 'package:friend_private/pages/conversations/widgets/processing_capture.dart';
import 'package:friend_private/pages/conversations/widgets/search_result_header_widget.dart';
import 'package:friend_private/pages/conversations/widgets/search_widget.dart';
Expand Down
2 changes: 0 additions & 2 deletions app/lib/pages/conversations/widgets/capture.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import 'package:flutter/material.dart';
import 'package:flutter/scheduler.dart';
import 'package:flutter_provider_utilities/flutter_provider_utilities.dart';
import 'package:friend_private/backend/schema/bt_device/bt_device.dart';
import 'package:friend_private/pages/capture/widgets/widgets.dart';
import 'package:friend_private/providers/capture_provider.dart';
Expand All @@ -9,7 +8,6 @@ import 'package:friend_private/providers/device_provider.dart';
import 'package:friend_private/providers/onboarding_provider.dart';
import 'package:friend_private/services/services.dart';
import 'package:friend_private/utils/audio/wav_bytes.dart';
import 'package:friend_private/widgets/dialog.dart';
import 'package:provider/provider.dart';

class LiteCaptureWidget extends StatefulWidget {
Expand Down
3 changes: 0 additions & 3 deletions app/lib/pages/conversations/widgets/local_sync.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
import 'dart:async';

import 'package:flutter/material.dart';
import 'package:friend_private/pages/conversations/sync_page.dart';
import 'package:friend_private/pages/sdcard/sdcard_transfer_progress.dart';
import 'package:friend_private/providers/capture_provider.dart';
import 'package:friend_private/providers/conversation_provider.dart';
import 'package:friend_private/utils/other/string_utils.dart';
import 'package:friend_private/utils/other/temp.dart';
import 'package:provider/provider.dart';

class LocalSyncWidget extends StatefulWidget {
Expand Down
3 changes: 0 additions & 3 deletions app/lib/pages/conversations/widgets/processing_capture.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'dart:async';

import 'package:flutter/material.dart';
import 'package:friend_private/backend/preferences.dart';
import 'package:friend_private/backend/schema/conversation.dart';
Expand All @@ -9,7 +7,6 @@ import 'package:friend_private/pages/conversation_capturing/page.dart';
import 'package:friend_private/pages/processing_conversations/page.dart';
import 'package:friend_private/providers/capture_provider.dart';
import 'package:friend_private/providers/connectivity_provider.dart';
import 'package:friend_private/providers/developer_mode_provider.dart';
import 'package:friend_private/providers/device_provider.dart';
import 'package:friend_private/utils/analytics/mixpanel.dart';
import 'package:friend_private/utils/enums.dart';
Expand Down
4 changes: 2 additions & 2 deletions app/lib/pages/home/page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import 'dart:io';
import 'package:flutter/material.dart';
import 'package:flutter_svg/flutter_svg.dart';
import 'package:flutter_foreground_task/flutter_foreground_task.dart';
import 'package:friend_private/gen/assets.gen.dart';
import 'package:friend_private/pages/persona/persona_provider.dart';
import 'package:friend_private/backend/http/api/users.dart';
import 'package:friend_private/backend/preferences.dart';
Expand All @@ -16,7 +17,6 @@ import 'package:friend_private/pages/conversations/conversations_page.dart';
import 'package:friend_private/pages/facts/page.dart';
import 'package:friend_private/pages/home/widgets/chat_apps_dropdown_widget.dart';
import 'package:friend_private/pages/persona/persona_profile.dart';
import 'package:friend_private/pages/persona/persona_provider.dart';
import 'package:friend_private/pages/home/widgets/speech_language_sheet.dart';
import 'package:friend_private/pages/settings/page.dart';
import 'package:friend_private/providers/app_provider.dart';
Expand Down Expand Up @@ -532,7 +532,7 @@ class _HomePageState extends State<HomePage> with WidgetsBindingObserver, Ticker
IconButton(
padding: const EdgeInsets.all(8.0),
icon: SvgPicture.asset(
'assets/images/ic_persona_profile.svg',
Assets.images.icPersonaProfile.path,
width: 28,
height: 28,
),
Expand Down
Loading