Fix missing curly brackets around variable 'name' in storage.py#2000
Merged
skywinder merged 2 commits intoMar 13, 2025
Conversation
…fixes BasedHardware#1947), remove unused 'files' list, add documentation
Collaborator
Author
|
I fixed the issue and noticed the files list was unused, so I removed it entirely for clarity and added documentation to the cleanup method. This change is safe to merge. |
Glucksberg
pushed a commit
to Glucksberg/omi-local
that referenced
this pull request
Apr 28, 2026
…dHardware#2000) Fixes BasedHardware#1947 - This PR adds the missing curly brackets around the variable 'name' in the f-string in storage.py. The bug was causing the URL to contain the literal string 'name' instead of the actual filename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1947 - This PR adds the missing curly brackets around the variable 'name' in the f-string in storage.py. The bug was causing the URL to contain the literal string 'name' instead of the actual filename.