Renaming from friend to omi

[mdmohsin7]

part of #1973

[skywinder]

will fix #1801

[beastoin]

1/ how did you solve the breaking changes on database for the existing memory > source: friend ?

@mdmohsin7

[mdmohsin7]

1/ I've added omi as conversation source and kept friend as is so as to not break the old memories. All the new memories will have the source as omi, and for the old memories we will have to migrate them if we want to remove the friend from the conversation source

@beastoin

[mdmohsin7]

Just checked the database and we are not fetching/filtering based on the source field anywhere. So there shouldn't be anything that will break the existing memories

[beastoin]

1/ so do we need to migrate the database ?
2/ does the old app allow an unknown enum ? for example, if the backend response convo source -> omi then does the app crash ? 🫣

@mdmohsin7

[mdmohsin7]

1/ For this PR we don't need to migrate unless we want all the old memories to have omi as source instead of friend
2/ Yes it does because in case of an unknown enum value, it falls back to friend as the source. It happens on the app side, but in the backend, the source will always be omi for new memories
Screenshot from old code:

I've tested creating memory with new backend and old app and it did not crash
@beastoin

[beastoin]

1/ ✅ ok, please change the source friend -> omi in the database as well(not this PR)
2/ ✅ ok
3/ could we get rid of this one sir https://github.com/BasedHardware/omi/pull/2016/files#diff-c48399e90223be2a16aa8c58b7949059dbc76237db453a0fc4c924ca4a6b348eR205 ? haha

@mdmohsin7

[mdmohsin7]

1/ Alright will write a script to do that, not sure how much time the script will take to run haha (I remember typesense script took 7-8hrs)
3/ sure, removed

@beastoin

[beastoin]

lgtm @mdmohsin7 🚀 / good luck to us.