Skip to content

refactor facts to memory#2071

Merged
beastoin merged 9 commits intomainfrom
facts-rename
Mar 28, 2025
Merged

refactor facts to memory#2071
beastoin merged 9 commits intomainfrom
facts-rename

Conversation

@mdmohsin7
Copy link
Copy Markdown
Member

@mdmohsin7 mdmohsin7 commented Mar 24, 2025

closes #1973

  • Refactor facts in app
  • Refactor facts in backend db
  • Refactor facts in redis
  • Refactor facts in all the remaining places in backend

@mdmohsin7 mdmohsin7 marked this pull request as ready for review March 27, 2025 17:33
@mdmohsin7
Copy link
Copy Markdown
Member Author

Deployment Plan:

  • Deploy to dev backend
  • Test current app with dev backend
  • Deploy to prod backend

Note: New routes have not been created for facts. That is there are no new /memories routes for facts because we already the /memories routes in use for conversations. We will be able to remove those old memories routes once we have the /conversations routes on prod for atleast a week or two

Pls review @beastoin

@beastoin beastoin merged commit e8806c0 into main Mar 28, 2025
1 check passed
@beastoin beastoin deleted the facts-rename branch March 28, 2025 02:50
@beastoin
Copy link
Copy Markdown
Collaborator

lgtm @mdmohsin7

Please deploy it to the dev env and test it.

For the routers, just create +1 version of every memory that needs to be renamed to facts. for example, if the current api is /v3/memories that get conversations, then just create new v4/memories that get facts.

Glucksberg pushed a commit to Glucksberg/omi-local that referenced this pull request Apr 28, 2026
closes BasedHardware#1973 

- [x] Refactor facts in app
- [x] Refactor facts in backend db
- [x] Refactor facts in redis
- [x] Refactor facts in all the remaining places in backend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Memory is now conversation, Fact is now memory. No more friend, omi now.

2 participants