Skip to content

First cut of a Friend device simulator on macOS#225

Merged
josancamon19 merged 1 commit intoBasedHardware:mainfrom
ebariaux:FriendSimulator
Jun 14, 2024
Merged

First cut of a Friend device simulator on macOS#225
josancamon19 merged 1 commit intoBasedHardware:mainfrom
ebariaux:FriendSimulator

Conversation

@ebariaux
Copy link
Copy Markdown
Contributor

@ebariaux ebariaux commented Jun 5, 2024

No description provided.

@diegoasua
Copy link
Copy Markdown

I was able to build and run the simulator on Mac and connected successfully to the iOS app but no transcripts came through

@ebariaux
Copy link
Copy Markdown
Contributor Author

ebariaux commented Jun 10, 2024

You need to press record on the simulator for sound to be sent over BLE.
Did you / can you enable sending the recordings to GCP ?
This would allow to check if sound is actually recorded, as I've read about several cases on no transcripts in Discord and that would help pinpoint where the problem is.

@diegoasua
Copy link
Copy Markdown

Gotcha transcripts coming through. LGTM. Separate device is less messy than incorporating this as a mock class inside Flutter app, I think your approach makes more sense than e.g. building a mock subclass and maintaining it

@diegoasua
Copy link
Copy Markdown

It would be great to write something about this in the README slash dev guide since I see it will be high usage?

@ebariaux
Copy link
Copy Markdown
Contributor Author

Great, glad it worked.
I'll update the docs to reference this, busy week so it'll probably be in a few days.

@josancamon19
Copy link
Copy Markdown
Contributor

lgtm :)

@josancamon19 josancamon19 merged commit fbada93 into BasedHardware:main Jun 14, 2024
@diegoasua
Copy link
Copy Markdown

diegoasua commented Jun 15, 2024

While this initially worked for me, after re-installing the app the BLE scan service can't find the simulator. Why? Can you reproduce @ebariaux ?

@ebariaux
Copy link
Copy Markdown
Contributor Author

Not sure which version of the app you're using.
The simulator uses the name of your Mac for advertising, this can't be changed.
Earlier version of the apps were scanning for a device name "Friend" (or "Super"), I made a PR to change that a scan based on service ID but this has been merged quite a while ago.

So one quick check you can do is renamed your Mac to "Friend" and see if that works.

@diegoasua
Copy link
Copy Markdown

Latest from App Store (1.0.6)

@diegoasua
Copy link
Copy Markdown

Can you try on your end reinstalling the app and scanning the mock device?

@ebariaux
Copy link
Copy Markdown
Contributor Author

Not working for me either, because somebody changed the connection logic, see ebariaux@ac95b8a
that's filtering on Friend as the device name, that's what I was explaining above.
It's impossible for the Mac to advertise this name unless that's what you name your Mac.
But testing is a pain because there are caches in bluetooth stacks on both Mac and iOS device.

What's the reason of the above commit ? Is that fixing something ?

@diegoasua
Copy link
Copy Markdown

why is it filtering again by name when UUID filtering was implemented? @josancamon19 do you know?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants