In firmware 2.0.2 to 2.0.8 update, battery showed 0% due to integer d…#2312
Closed
melmathari wants to merge 1 commit intoBasedHardware:mainfrom
melmathari:issue-1925
Closed
In firmware 2.0.2 to 2.0.8 update, battery showed 0% due to integer d…#2312melmathari wants to merge 1 commit intoBasedHardware:mainfrom melmathari:issue-1925
melmathari wants to merge 1 commit intoBasedHardware:mainfrom
melmathari:issue-1925
Conversation
|
@melmathari is attempting to deploy a commit to the kodjima33's projects Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
Hi @melmathari, How did you test it if you don’t have a physical Omi device? you need to get device and test it by yourself. Also cleanup code from the useless comments at same time keep info that was there. probably ai generation cause this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in voltage calculation formula. Integer division of (R1 + R2) / R2 truncated the result, causing the battery voltage to be underestimated. For the fix i used floating point calculation to get accurate voltage divider ratio and convert back to integer for final result
/claim #1925