Skip to content

Added firebase auth to web app and implemented the app creation form#2426

Closed
ArslanKamchybekov wants to merge 1 commit into
BasedHardware:mainfrom
ArslanKamchybekov:main
Closed

Added firebase auth to web app and implemented the app creation form#2426
ArslanKamchybekov wants to merge 1 commit into
BasedHardware:mainfrom
ArslanKamchybekov:main

Conversation

@ArslanKamchybekov
Copy link
Copy Markdown

No description provided.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 23, 2025

@ArslanKamchybekov is attempting to deploy a commit to the kodjima33's projects Team on Vercel.

A member of the Team first needs to authorize it.

@ArslanKamchybekov ArslanKamchybekov changed the title added firebase auth to web app and implemented the app creation form Added firebase auth to web app and implemented the app creation form May 23, 2025
@beastoin
Copy link
Copy Markdown
Collaborator

@ArslanKamchybekov

1/ can you add the desc, the issue ref(if applicable), your tests as well.

Copy link
Copy Markdown
Member

@mdmohsin7 mdmohsin7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now we will be going with #2430, thanks for your contribution @ArslanKamchybekov

# Convert ISO datetime strings to Unix timestamps if provided
start_timestamp = None
end_timestamp = None
# @router.post("/v1/conversations/search", response_model=dict, tags=['conversations'])
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated change, why do we have to comment the search endpoint?

const [success, setSuccess] = useState('');

const categories = [
{ value: 'utility', label: 'Utility' },
Copy link
Copy Markdown
Member

@mdmohsin7 mdmohsin7 May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls use the endpoints to fetch this data, you can check api.omi.me/docs

throw new Error('You must be logged in to create an app');
}

const adminKey = process.env.NEXT_PUBLIC_ADMIN_KEY || 'test123';
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

admin key shouldn't be needed

@mdmohsin7 mdmohsin7 marked this pull request as draft May 26, 2025 19:23
@beastoin
Copy link
Copy Markdown
Collaborator

beastoin commented Jun 1, 2025

closed due to no updates in > 3 days. feel free to reopen it once it's ready.

@beastoin beastoin closed this Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants