Added firebase auth to web app and implemented the app creation form#2426
Closed
ArslanKamchybekov wants to merge 1 commit into
Closed
Added firebase auth to web app and implemented the app creation form#2426ArslanKamchybekov wants to merge 1 commit into
ArslanKamchybekov wants to merge 1 commit into
Conversation
|
@ArslanKamchybekov is attempting to deploy a commit to the kodjima33's projects Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
1/ can you add the desc, the issue ref(if applicable), your tests as well. |
mdmohsin7
requested changes
May 26, 2025
Member
mdmohsin7
left a comment
There was a problem hiding this comment.
For now we will be going with #2430, thanks for your contribution @ArslanKamchybekov
| # Convert ISO datetime strings to Unix timestamps if provided | ||
| start_timestamp = None | ||
| end_timestamp = None | ||
| # @router.post("/v1/conversations/search", response_model=dict, tags=['conversations']) |
Member
There was a problem hiding this comment.
unrelated change, why do we have to comment the search endpoint?
| const [success, setSuccess] = useState(''); | ||
|
|
||
| const categories = [ | ||
| { value: 'utility', label: 'Utility' }, |
Member
There was a problem hiding this comment.
pls use the endpoints to fetch this data, you can check api.omi.me/docs
| throw new Error('You must be logged in to create an app'); | ||
| } | ||
|
|
||
| const adminKey = process.env.NEXT_PUBLIC_ADMIN_KEY || 'test123'; |
Member
There was a problem hiding this comment.
admin key shouldn't be needed
Collaborator
|
closed due to no updates in > 3 days. feel free to reopen it once it's ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.