Skip to content

fix: timeout#3051

Merged
beastoin merged 2 commits intoBasedHardware:mainfrom
krushnarout:fix/timeout
Sep 29, 2025
Merged

fix: timeout#3051
beastoin merged 2 commits intoBasedHardware:mainfrom
krushnarout:fix/timeout

Conversation

@krushnarout
Copy link
Copy Markdown
Member

closes #2848

@krushnarout
Copy link
Copy Markdown
Member Author

Tested other options, working fine

@mdmohsin7
Copy link
Copy Markdown
Member

fix the issues still pending to be fixed with this one, especially never end mode and test thoroughly @krushnarout reopening

What exactly was the issue @krushnarout?

@krushnarout
Copy link
Copy Markdown
Member Author

What exactly was the issue @krushnarout?

@mdmohsin7 For the never case, it wasn't working properly before. Now, instead of never, it's changed to maximum of 4 hours here, that's why make these changes to ui.

@beastoin
Copy link
Copy Markdown
Collaborator

lgtm btw read about how to create a good PR and never give us a PR with a poor description like this again omi TODO / bounties

@krushnarout

@beastoin beastoin merged commit 26e9737 into BasedHardware:main Sep 29, 2025
@krushnarout
Copy link
Copy Markdown
Member Author

lgtm btw read about how to create a good PR and never give us a PR with a poor description like this again omi TODO / bounties

Got it, i didn't add proper description because this was discussed with Aarav.

@krushnarout krushnarout deleted the fix/timeout branch September 29, 2025 03:10
@aaravgarg
Copy link
Copy Markdown
Collaborator

lgtm btw read about how to create a good PR and never give us a PR with a poor description like this again omi TODO / bounties

Got it, i didn't add proper description because this was discussed with Aarav.

Sometimes reviewer myt still be someone else. so its important to mention, even if its a quick description.

@krushnarout
Copy link
Copy Markdown
Member Author

Sometimes reviewer myt still be someone else. so it's important to mention, even if it's a quick description.

Noted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add ability to change convo end pause duration

4 participants