Skip to content

feat: select audio input#3056

Merged
beastoin merged 5 commits into
BasedHardware:mainfrom
krushnarout:feat/select-audio-input
Oct 9, 2025
Merged

feat: select audio input#3056
beastoin merged 5 commits into
BasedHardware:mainfrom
krushnarout:feat/select-audio-input

Conversation

@krushnarout
Copy link
Copy Markdown
Member

closes #3013

@aaravgarg aaravgarg requested a review from mdmohsin7 September 27, 2025 21:48
@mdmohsin7
Copy link
Copy Markdown
Member

Demo video pls @krushnarout

@krushnarout
Copy link
Copy Markdown
Member Author

krushnarout commented Sep 28, 2025

Demo video pls @krushnarout

here's demo

Screen.Recording.2025-09-29.at.12.21.34.AM.mov

I need to fix some issues. I'll let you know once it's done

@aaravgarg
Copy link
Copy Markdown
Collaborator

ui/ux lgtm. @krushnarout finish up asap and then @mdmohsin7 review asap

@krushnarout krushnarout marked this pull request as ready for review September 30, 2025 07:17
@krushnarout
Copy link
Copy Markdown
Member Author

Screen.Recording.2025-09-30.at.2.27.06.PM.mov

@beastoin beastoin merged commit e78f1b7 into BasedHardware:main Oct 9, 2025
@beastoin
Copy link
Copy Markdown
Collaborator

beastoin commented Oct 9, 2025

interesting. lgmt @krushnarout

@mdmohsin7 i remembered that you mentioned the issue of changing the input sources that might cause a problem - a crash or something else. could you help recall it so that @krushnarout can check?

@aaravgarg
Copy link
Copy Markdown
Collaborator

Screen.Recording.2025-09-30.at.2.27.06.PM.mov

can the connection process not be made faster and smoother, in other apps when i change audio source its almost instant

@krushnarout
Copy link
Copy Markdown
Member Author

@mdmohsin7 i remembered that you mentioned the issue of changing the input sources that might cause a problem - a crash or something else. could you help recall it so that @krushnarout can check?

I handle that by stopping the current audio engine, removing the existing microphone tap, resetting the audio engine to a clean state, installing a new microphone tap, and then starting the audio engine again.

@krushnarout krushnarout deleted the feat/select-audio-input branch October 9, 2025 03:56
@krushnarout
Copy link
Copy Markdown
Member Author

can the connection process not be made faster and smoother, in other apps when i change audio source its almost instant

It’s a 5 second delay due to reinitializing the websocket and audio capture session each time the audio source changes

Glucksberg pushed a commit to Glucksberg/omi-local that referenced this pull request Apr 28, 2026
* feat: select audio input

* feat: make ui good

* fix: show snackbar

* fix: frequent audio device switches work properly

* fix: close dropdown on outside click and fix device display issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

select audio input in omi desktop app

4 participants