fix: self hosting with non-ssl backend#3103
Merged
mdmohsin7 merged 1 commit intoBasedHardware:mainfrom Oct 3, 2025
Merged
Conversation
mdmohsin7
approved these changes
Oct 3, 2025
Glucksberg
pushed a commit
to Glucksberg/omi-local
that referenced
this pull request
Apr 28, 2026
This pull request updates the way the WebSocket URL is constructed in the `TranscriptSegmentSocketService` class to more robustly handle both `http` and `https` base URLs. This ensures the correct WebSocket protocol (`ws://` or `wss://`) is used regardless of the original API base URL scheme. **WebSocket URL construction improvement:** * Updated the URL construction logic in `transcription_connection.dart` to replace both `https://` with `wss://` and `http://` with `ws://`, ensuring compatibility with different API base URL schemes. The issue previously was that it would not replace http so transcription would not work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the way the WebSocket URL is constructed in the
TranscriptSegmentSocketServiceclass to more robustly handle bothhttpandhttpsbase URLs. This ensures the correct WebSocket protocol (ws://orwss://) is used regardless of the original API base URL scheme.WebSocket URL construction improvement:
transcription_connection.dartto replace bothhttps://withwss://andhttp://withws://, ensuring compatibility with different API base URL schemes.The issue previously was that it would not replace http so transcription would not work.