feat: support setting for todoist and google tasks#3438
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds settings pages for the new Todoist and Google Tasks integrations, allowing users to manage their connections. The implementation is functional but introduces significant code duplication between the two new settings pages. I've identified a critical logical issue in the disconnection flow for Google Tasks on Android platforms that needs to be addressed. Additionally, there are opportunities to refactor duplicated navigation logic to improve the code's maintainability. My review includes specific suggestions for these improvements.
Comment on lines
+8
to
+202
| class GoogleTasksSettingsPage extends StatefulWidget { | ||
| const GoogleTasksSettingsPage({super.key}); | ||
|
|
||
| @override | ||
| State<GoogleTasksSettingsPage> createState() => _GoogleTasksSettingsPageState(); | ||
| } | ||
|
|
||
| class _GoogleTasksSettingsPageState extends State<GoogleTasksSettingsPage> { | ||
| final GoogleTasksService _googleTasksService = GoogleTasksService(); | ||
|
|
||
| Future<void> _disconnectGoogleTasks() async { | ||
| // Capture context references before any async operations | ||
| final provider = context.read<TaskIntegrationProvider>(); | ||
| final navigator = Navigator.of(context); | ||
| final scaffoldMessenger = ScaffoldMessenger.of(context); | ||
|
|
||
| final confirmed = await showDialog<bool>( | ||
| context: context, | ||
| builder: (BuildContext context) { | ||
| return AlertDialog( | ||
| backgroundColor: const Color(0xFF1C1C1E), | ||
| shape: RoundedRectangleBorder( | ||
| borderRadius: BorderRadius.circular(16), | ||
| ), | ||
| title: const Text( | ||
| 'Disconnect from Google Tasks?', | ||
| style: TextStyle(color: Colors.white), | ||
| ), | ||
| content: const Text( | ||
| 'This will remove your Google Tasks authentication. You\'ll need to reconnect to use it again.', | ||
| style: TextStyle(color: Color(0xFF8E8E93)), | ||
| ), | ||
| actions: [ | ||
| TextButton( | ||
| onPressed: () => Navigator.of(context).pop(false), | ||
| child: const Text( | ||
| 'Cancel', | ||
| style: TextStyle(color: Color(0xFF8E8E93)), | ||
| ), | ||
| ), | ||
| TextButton( | ||
| onPressed: () => Navigator.of(context).pop(true), | ||
| child: const Text( | ||
| 'Disconnect', | ||
| style: TextStyle(color: Colors.red), | ||
| ), | ||
| ), | ||
| ], | ||
| ); | ||
| }, | ||
| ); | ||
|
|
||
| if (confirmed == true) { | ||
| await _googleTasksService.disconnect(); | ||
|
|
||
| if (!mounted) return; | ||
|
|
||
| // Delete connection from Firebase | ||
| await provider.deleteConnection('google_tasks'); | ||
|
|
||
| // Also clear from task integrations if Google Tasks was selected | ||
| if (provider.selectedApp.key == 'google_tasks') { | ||
| // Default to Google Tasks on Android, Apple Reminders on Apple platforms | ||
| final defaultApp = | ||
| PlatformService.isApple ? TaskIntegrationApp.appleReminders : TaskIntegrationApp.googleTasks; | ||
| await provider.setSelectedApp(defaultApp); | ||
| debugPrint('✓ Task integration disabled: Google Tasks - switched to ${defaultApp.key}'); | ||
| } | ||
|
|
||
| provider.refresh(); | ||
|
|
||
| // Show snackbar before popping to avoid using deactivated context | ||
| scaffoldMessenger.showSnackBar( | ||
| const SnackBar( | ||
| content: Text('Disconnected from Google Tasks'), | ||
| duration: Duration(seconds: 2), | ||
| ), | ||
| ); | ||
|
|
||
| navigator.pop(); | ||
| } | ||
| } | ||
|
|
||
| @override | ||
| Widget build(BuildContext context) { | ||
| return Scaffold( | ||
| backgroundColor: const Color(0xFF000000), | ||
| appBar: AppBar( | ||
| backgroundColor: const Color(0xFF000000), | ||
| elevation: 0, | ||
| leading: IconButton( | ||
| icon: const Icon(Icons.arrow_back, color: Colors.white), | ||
| onPressed: () => Navigator.pop(context), | ||
| ), | ||
| title: const Text( | ||
| 'Google Tasks Settings', | ||
| style: TextStyle( | ||
| color: Colors.white, | ||
| fontSize: 18, | ||
| fontWeight: FontWeight.w600, | ||
| ), | ||
| ), | ||
| centerTitle: true, | ||
| ), | ||
| body: SafeArea( | ||
| child: Padding( | ||
| padding: const EdgeInsets.all(20), | ||
| child: Column( | ||
| crossAxisAlignment: CrossAxisAlignment.start, | ||
| children: [ | ||
| // Connected Status | ||
| Container( | ||
| padding: const EdgeInsets.all(12), | ||
| margin: const EdgeInsets.only(bottom: 24), | ||
| decoration: BoxDecoration( | ||
| color: Colors.green.withOpacity(0.1), | ||
| borderRadius: BorderRadius.circular(8), | ||
| border: Border.all(color: Colors.green.withOpacity(0.3)), | ||
| ), | ||
| child: const Row( | ||
| children: [ | ||
| Icon(Icons.check_circle, color: Colors.green, size: 16), | ||
| SizedBox(width: 8), | ||
| Expanded( | ||
| child: Text( | ||
| 'Connected to Google Tasks', | ||
| style: TextStyle( | ||
| color: Colors.green, | ||
| fontSize: 14, | ||
| ), | ||
| ), | ||
| ), | ||
| ], | ||
| ), | ||
| ), | ||
|
|
||
| // Info Section | ||
| const Text( | ||
| 'Account', | ||
| style: TextStyle( | ||
| color: Colors.white, | ||
| fontSize: 18, | ||
| fontWeight: FontWeight.w600, | ||
| ), | ||
| ), | ||
| const SizedBox(height: 8), | ||
| const Text( | ||
| 'Your action items will be synced to your Google Tasks account', | ||
| style: TextStyle( | ||
| color: Color(0xFF8E8E93), | ||
| fontSize: 14, | ||
| ), | ||
| ), | ||
| const SizedBox(height: 32), | ||
|
|
||
| const Spacer(), | ||
|
|
||
| // Disconnect Button | ||
| GestureDetector( | ||
| onTap: _disconnectGoogleTasks, | ||
| child: Container( | ||
| padding: const EdgeInsets.all(16), | ||
| decoration: BoxDecoration( | ||
| color: Colors.red.withOpacity(0.1), | ||
| borderRadius: BorderRadius.circular(12), | ||
| border: Border.all(color: Colors.red.withOpacity(0.3)), | ||
| ), | ||
| child: const Row( | ||
| mainAxisAlignment: MainAxisAlignment.center, | ||
| children: [ | ||
| Icon( | ||
| Icons.logout, | ||
| color: Colors.red, | ||
| size: 20, | ||
| ), | ||
| SizedBox(width: 12), | ||
| Text( | ||
| 'Disconnect from Google Tasks', | ||
| style: TextStyle( | ||
| color: Colors.red, | ||
| fontSize: 16, | ||
| fontWeight: FontWeight.w500, | ||
| ), | ||
| ), | ||
| ], | ||
| ), | ||
| ), | ||
| ), | ||
| ], | ||
| ), | ||
| ), | ||
| ), | ||
| ); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
This page contains a significant amount of code that is duplicated in todoist_settings_page.dart. To improve maintainability and adhere to the DRY principle, this widget should be refactored into a generic component that can be configured for different task integrations. This would involve passing parameters like the service instance, app name, and app key.
Additionally, this file uses withOpacity(), which violates the project's coding guidelines. Please use the withValues({double? alpha}) extension method instead.1
Rules References
Footnotes
-
Use the custom
withValues({double? alpha})extension method instead of the deprecatedwithOpacity()to modify a color's opacity. ↩
Comment on lines
+8
to
+202
| class TodoistSettingsPage extends StatefulWidget { | ||
| const TodoistSettingsPage({super.key}); | ||
|
|
||
| @override | ||
| State<TodoistSettingsPage> createState() => _TodoistSettingsPageState(); | ||
| } | ||
|
|
||
| class _TodoistSettingsPageState extends State<TodoistSettingsPage> { | ||
| final TodoistService _todoistService = TodoistService(); | ||
|
|
||
| Future<void> _disconnectTodoist() async { | ||
| // Capture context references before any async operations | ||
| final provider = context.read<TaskIntegrationProvider>(); | ||
| final navigator = Navigator.of(context); | ||
| final scaffoldMessenger = ScaffoldMessenger.of(context); | ||
|
|
||
| final confirmed = await showDialog<bool>( | ||
| context: context, | ||
| builder: (BuildContext context) { | ||
| return AlertDialog( | ||
| backgroundColor: const Color(0xFF1C1C1E), | ||
| shape: RoundedRectangleBorder( | ||
| borderRadius: BorderRadius.circular(16), | ||
| ), | ||
| title: const Text( | ||
| 'Disconnect from Todoist?', | ||
| style: TextStyle(color: Colors.white), | ||
| ), | ||
| content: const Text( | ||
| 'This will remove your Todoist authentication. You\'ll need to reconnect to use it again.', | ||
| style: TextStyle(color: Color(0xFF8E8E93)), | ||
| ), | ||
| actions: [ | ||
| TextButton( | ||
| onPressed: () => Navigator.of(context).pop(false), | ||
| child: const Text( | ||
| 'Cancel', | ||
| style: TextStyle(color: Color(0xFF8E8E93)), | ||
| ), | ||
| ), | ||
| TextButton( | ||
| onPressed: () => Navigator.of(context).pop(true), | ||
| child: const Text( | ||
| 'Disconnect', | ||
| style: TextStyle(color: Colors.red), | ||
| ), | ||
| ), | ||
| ], | ||
| ); | ||
| }, | ||
| ); | ||
|
|
||
| if (confirmed == true) { | ||
| await _todoistService.disconnect(); | ||
|
|
||
| if (!mounted) return; | ||
|
|
||
| // Delete connection from Firebase | ||
| await provider.deleteConnection('todoist'); | ||
|
|
||
| // Also clear from task integrations if Todoist was selected | ||
| if (provider.selectedApp.key == 'todoist') { | ||
| // Default to Google Tasks on Android, Apple Reminders on Apple platforms | ||
| final defaultApp = | ||
| PlatformService.isApple ? TaskIntegrationApp.appleReminders : TaskIntegrationApp.googleTasks; | ||
| await provider.setSelectedApp(defaultApp); | ||
| debugPrint('✓ Task integration disabled: Todoist - switched to ${defaultApp.key}'); | ||
| } | ||
|
|
||
| provider.refresh(); | ||
|
|
||
| // Show snackbar before popping to avoid using deactivated context | ||
| scaffoldMessenger.showSnackBar( | ||
| const SnackBar( | ||
| content: Text('Disconnected from Todoist'), | ||
| duration: Duration(seconds: 2), | ||
| ), | ||
| ); | ||
|
|
||
| navigator.pop(); | ||
| } | ||
| } | ||
|
|
||
| @override | ||
| Widget build(BuildContext context) { | ||
| return Scaffold( | ||
| backgroundColor: const Color(0xFF000000), | ||
| appBar: AppBar( | ||
| backgroundColor: const Color(0xFF000000), | ||
| elevation: 0, | ||
| leading: IconButton( | ||
| icon: const Icon(Icons.arrow_back, color: Colors.white), | ||
| onPressed: () => Navigator.pop(context), | ||
| ), | ||
| title: const Text( | ||
| 'Todoist Settings', | ||
| style: TextStyle( | ||
| color: Colors.white, | ||
| fontSize: 18, | ||
| fontWeight: FontWeight.w600, | ||
| ), | ||
| ), | ||
| centerTitle: true, | ||
| ), | ||
| body: SafeArea( | ||
| child: Padding( | ||
| padding: const EdgeInsets.all(20), | ||
| child: Column( | ||
| crossAxisAlignment: CrossAxisAlignment.start, | ||
| children: [ | ||
| // Connected Status | ||
| Container( | ||
| padding: const EdgeInsets.all(12), | ||
| margin: const EdgeInsets.only(bottom: 24), | ||
| decoration: BoxDecoration( | ||
| color: Colors.green.withOpacity(0.1), | ||
| borderRadius: BorderRadius.circular(8), | ||
| border: Border.all(color: Colors.green.withOpacity(0.3)), | ||
| ), | ||
| child: const Row( | ||
| children: [ | ||
| Icon(Icons.check_circle, color: Colors.green, size: 16), | ||
| SizedBox(width: 8), | ||
| Expanded( | ||
| child: Text( | ||
| 'Connected to Todoist', | ||
| style: TextStyle( | ||
| color: Colors.green, | ||
| fontSize: 14, | ||
| ), | ||
| ), | ||
| ), | ||
| ], | ||
| ), | ||
| ), | ||
|
|
||
| // Info Section | ||
| const Text( | ||
| 'Account', | ||
| style: TextStyle( | ||
| color: Colors.white, | ||
| fontSize: 18, | ||
| fontWeight: FontWeight.w600, | ||
| ), | ||
| ), | ||
| const SizedBox(height: 8), | ||
| const Text( | ||
| 'Your action items will be synced to your Todoist account', | ||
| style: TextStyle( | ||
| color: Color(0xFF8E8E93), | ||
| fontSize: 14, | ||
| ), | ||
| ), | ||
| const SizedBox(height: 32), | ||
|
|
||
| const Spacer(), | ||
|
|
||
| // Disconnect Button | ||
| GestureDetector( | ||
| onTap: _disconnectTodoist, | ||
| child: Container( | ||
| padding: const EdgeInsets.all(16), | ||
| decoration: BoxDecoration( | ||
| color: Colors.red.withOpacity(0.1), | ||
| borderRadius: BorderRadius.circular(12), | ||
| border: Border.all(color: Colors.red.withOpacity(0.3)), | ||
| ), | ||
| child: const Row( | ||
| mainAxisAlignment: MainAxisAlignment.center, | ||
| children: [ | ||
| Icon( | ||
| Icons.logout, | ||
| color: Colors.red, | ||
| size: 20, | ||
| ), | ||
| SizedBox(width: 12), | ||
| Text( | ||
| 'Disconnect from Todoist', | ||
| style: TextStyle( | ||
| color: Colors.red, | ||
| fontSize: 16, | ||
| fontWeight: FontWeight.w500, | ||
| ), | ||
| ), | ||
| ], | ||
| ), | ||
| ), | ||
| ), | ||
| ], | ||
| ), | ||
| ), | ||
| ), | ||
| ); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
This page contains a significant amount of code that is duplicated in google_tasks_settings_page.dart. To improve maintainability and adhere to the DRY principle, this widget should be refactored into a generic component that can be configured for different task integrations. This would involve passing parameters like the service instance, app name, and app key.
Additionally, this file uses withOpacity(), which violates the project's coding guidelines. Please use the withValues({double? alpha}) extension method instead.1
Rules References
Footnotes
-
Use the custom
withValues({double? alpha})extension method instead of the deprecatedwithOpacity()to modify a color's opacity. ↩
Member
Author
|
Added setting support for todoist and google tasks and reduced duplication in integration settings by half demo: ScreenRecording_11-15-2025.23-39-41_1.MP4 |
Glucksberg
pushed a commit
to Glucksberg/omi-local
that referenced
this pull request
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.