deadlock in pusher thread#3449
Merged
beastoin merged 2 commits intoBasedHardware:mainfrom Nov 19, 2025
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to fix a deadlock in the pusher thread during system shutdown by aborting the thread. While this might seem to solve the issue, using k_thread_abort is a dangerous practice that can lead to resource leaks and other deadlocks. My review provides a critical comment suggesting a safer, more robust way to terminate the thread gracefully using signaling and joining. This will prevent the original deadlock without introducing new, subtle bugs.
Collaborator
|
lgtm @TuEmb |
Glucksberg
pushed a commit
to Glucksberg/omi-local
that referenced
this pull request
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there is a
deadlockwhen the system turns off (try to spam the button). thepusherthread got stuck at this time=> need to abort the
pusherthread before going offit maybe related to #3401