enhance the memory experience; remove lines limits; unify the memory updates/creates dialog#3485
Merged
enhance the memory experience; remove lines limits; unify the memory updates/creates dialog#3485
Conversation
…updates/creates dialog
Collaborator
Author
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the memory creation and editing experience by removing line limits on memory text and unifying the create/edit dialogs into a more consistent UI. The refactoring of MemoryEditSheet and MemoryDialog to StatefulWidgets with proper controller management is a good improvement.
My review focuses on a few key areas:
- Adherence to the repository's coding guidelines, specifically regarding color opacity modification.
- A minor user experience regression where the save button's text is no longer dynamic.
- A significant code duplication issue between the newly refactored
MemoryDialogandMemoryEditSheetwidgets, which should be addressed to improve maintainability.
Glucksberg
pushed a commit
to Glucksberg/omi-local
that referenced
this pull request
Apr 28, 2026
…updates/creates dialog (BasedHardware#3485)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what's included?
demo: #3485 (comment)
deploy:
#3483