Skip to content

Add get omi for mac#3510

Merged
aaravgarg merged 3 commits intomainfrom
mac
Nov 27, 2025
Merged

Add get omi for mac#3510
aaravgarg merged 3 commits intomainfrom
mac

Conversation

@krushnarout
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the 'Share Omi for Mac' settings item to 'Get Omi for Mac' and changes the associated URL to a general download page. While the label and URL change are improvements, the action performed on tap is inconsistent with the new label. It uses Share.share which opens a share sheet, instead of directly opening the download URL. My review suggests correcting this by using url_launcher to provide a more intuitive user experience, and also notes that a try-catch block can be omitted for launching a hardcoded and valid URL.

Comment on lines 404 to 407
onTap: () async {
Navigator.pop(context);
await Share.share('https://apps.apple.com/us/app/omi-ai-scale-yourself/id6502156163');
await Share.share('https://www.omi.me/pages/download');
},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The title of this settings item has been changed to 'Get Omi for Mac', which implies that tapping it will take the user to a place where they can download the Mac application. However, the onTap action uses Share.share, which opens a share sheet. This is inconsistent with the button's label and creates a confusing user experience.

To align the action with the user's expectation, you should use url_launcher to open the download page directly in the user's default browser. A try-catch block can be omitted for operations with a negligible chance of failure, such as launching a hardcoded and valid URL, to avoid unnecessary code complexity 1.

Suggested change
onTap: () async {
Navigator.pop(context);
await Share.share('https://apps.apple.com/us/app/omi-ai-scale-yourself/id6502156163');
await Share.share('https://www.omi.me/pages/download');
},
onTap: () async {
Navigator.pop(context);
final Uri url = Uri.parse('https://www.omi.me/pages/download');
await launchUrl(url, mode: LaunchMode.externalApplication);
},

Rules References

Footnotes

  1. A try-catch block can be omitted for operations with a negligible chance of failure, such as launching a hardcoded and valid URL, to avoid unnecessary code complexity.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krushnarout this is correct, it shd open link not share it

@aaravgarg
Copy link
Copy Markdown
Collaborator

right now its only mac so link shd be still mac

all u hv to do is instead of sharing it opens the link

@aaravgarg aaravgarg merged commit 72f1d46 into main Nov 27, 2025
1 check passed
@aaravgarg aaravgarg deleted the mac branch November 27, 2025 06:32
Glucksberg pushed a commit to Glucksberg/omi-local that referenced this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants