Conversation
- Customize ask omi shortkey. - Resize floating windows. - Chat with pdf files.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a significant refactoring that simplifies the SwiftUI views by consolidating the AI conversation UI into the FloatingControlBar. It also introduces new features like customizable shortcuts for 'Ask Omi', window resizing, and the ability to chat with PDF files. The code is well-structured, especially the new additions in FloatingControlBar.swift and GlobalShortcutManager.swift.
My review includes two main points of feedback:
- A security/collaboration issue regarding a hardcoded
DEVELOPMENT_TEAMID in the project file. - A bug in the shortcut recording logic that allows setting modifier-only shortcuts.
Overall, this is a great improvement to the codebase. Addressing these points will enhance security and fix a bug in the new shortcut feature.
beastoin
changed the title
|
@beastoin this is bad im sorry
Currently, if I click CMD+RTRN shortcut (while omi is hidden), it still triggers omi. As a user, I don't want "ask omi" to activate IF ITs hidden. I want to be able to HIDE omi with CMD + \ so that I could use CMD + RTRN shortcut in superhuman (ask omi) |
…asedHardware#3527) * Simplify SwiftUI views and consolidate shared components. features: - Customize ask omi shortkey. - Resize floating windows. - Chat with pdf files. * Reset team
2 participants
simplify swiftui views and consolidate shared components and more.
ask omidemo
deploy
#3515 #3500