Conversation
Co-authored-by: aider (anthropic/claude-sonnet-4-5-20250929) <aider@aider.chat>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces several enhancements to the floating control bar and the 'Ask omi' feature on macOS. The changes include adding a guard to prevent UI updates when the AI conversation is not visible, and fixing the resizability of the control bar. It also improves the reliability of showing the AI conversation from a global shortcut. However, I've found a critical race condition when opening the chat window from the menu bar, which is not handled with the same care as the global shortcut. I've also suggested a refactoring to reduce code duplication and prevent similar bugs in the future.
Glucksberg
pushed a commit
to Glucksberg/omi-local
that referenced
this pull request
Apr 28, 2026
* Prevent window resize when AI conversation is closed * Activate app before showing floating control bar and AI chat * fix: disable window resizing for non-response views Co-authored-by: aider (anthropic/claude-sonnet-4-5-20250929) <aider@aider.chat> --------- Co-authored-by: aider (anthropic/claude-sonnet-4-5-20250929) <aider@aider.chat>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.