Skip to content

Revert "Meeting detection in all apps + macos calendars integration (…#3618

Merged
beastoin merged 1 commit intomainfrom
v6qq5_rv
Dec 5, 2025
Merged

Revert "Meeting detection in all apps + macos calendars integration (…#3618
beastoin merged 1 commit intomainfrom
v6qq5_rv

Conversation

@beastoin
Copy link
Copy Markdown
Collaborator

@beastoin beastoin commented Dec 5, 2025

reason for reverting: the recording does not work; the transcripts do not show up.

the symptoms are:

1/ the mic and system waveform do not show up
2/ cannot click the resume button in the flutter main window after hitting pause
3/ the timer in the control bar (macos native) keeps counting even after stopping.

This reverts commit 3f5ba2a, reversing changes made to 5e45e2d.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts the 'Meeting detection in all apps + macos calendars integration' feature. The changes are extensive, removing numerous files and code related to this feature across the Flutter app, native macOS code, and the backend.

A critical improvement in this revert is the re-enabling of the App Sandbox for the macOS application, which was disabled by the original feature. This is a crucial security enhancement.

The revert appears clean and thorough, correctly removing related providers, services, UI components, and backend logic. The application's behavior, such as window termination on macOS and onboarding permissions, has been correctly reverted to its previous state. Overall, this is a well-executed revert that removes the feature and fixes a significant security issue.

@beastoin beastoin merged commit 36d02ea into main Dec 5, 2025
1 check passed
@beastoin beastoin deleted the v6qq5_rv branch December 5, 2025 05:20
Glucksberg pushed a commit to Glucksberg/omi-local that referenced this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant