Conversation
There was a problem hiding this comment.
Code Review
This pull request reverts the 'Meeting detection in all apps + macos calendars integration' feature. The changes are extensive, removing numerous files and code related to this feature across the Flutter app, native macOS code, and the backend.
A critical improvement in this revert is the re-enabling of the App Sandbox for the macOS application, which was disabled by the original feature. This is a crucial security enhancement.
The revert appears clean and thorough, correctly removing related providers, services, UI components, and backend logic. The application's behavior, such as window termination on macOS and onboarding permissions, has been correctly reverted to its previous state. Overall, this is a well-executed revert that removes the feature and fixes a significant security issue.
…asedHardware#3478)" (BasedHardware#3618) This reverts commit 3f5ba2a, reversing changes made to 5e45e2d.
reason for reverting: the recording does not work; the transcripts do not show up.
the symptoms are:
1/ the mic and system waveform do not show up
2/ cannot click the resume button in the flutter main window after hitting pause
3/ the timer in the control bar (macos native) keeps counting even after stopping.
This reverts commit 3f5ba2a, reversing changes made to 5e45e2d.