Ensuring only the latest in-progress conversation is considered#3645
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces significant improvements to conversation management by implementing Redis-based distributed locking to prevent race conditions with in-progress conversations. It also adds logic to clean up stale and orphaned conversations, ensuring data integrity and system stability. The changes are well-structured and address a critical concurrency issue. I have one suggestion to optimize a database query for better performance and efficiency.
beastoin
added a commit
that referenced
this pull request
Dec 8, 2025
* Revert "Move cleanup_stale_conversations to main task group (#3648)" This reverts commit c4399f5. * Revert "R83tq stable stt (#3647)" This reverts commit bd7f5f9. * Revert "Add timeout check for orphaned conversations, status check to create new conversation if not in_progress (#3646)" This reverts commit 6ad9f28. * Revert "Ensuring only the latest in-progress conversation is considered (#3645)" This reverts commit 15b4bb1. * Reduce the complexity on transcribing; faster cleanup with tasks-based
Glucksberg
pushed a commit
to Glucksberg/omi-local
that referenced
this pull request
Apr 28, 2026
Glucksberg
pushed a commit
to Glucksberg/omi-local
that referenced
this pull request
Apr 28, 2026
* Revert "Move cleanup_stale_conversations to main task group (BasedHardware#3648)" This reverts commit c4399f5. * Revert "R83tq stable stt (BasedHardware#3647)" This reverts commit bd7f5f9. * Revert "Add timeout check for orphaned conversations, status check to create new conversation if not in_progress (BasedHardware#3646)" This reverts commit 6ad9f28. * Revert "Ensuring only the latest in-progress conversation is considered (BasedHardware#3645)" This reverts commit 15b4bb1. * Reduce the complexity on transcribing; faster cleanup with tasks-based
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.