feat: hosted MCP server by neooriginal · Pull Request #3655 · BasedHardware/omi

neooriginal · 2025-12-08T13:36:15Z

compatible with apps like poke.com and chatgpt web.
for apps that require this kind of format:

This pull request introduces a new "Pre-hosted MCP" section in the developer settings page and adds backend support for a new mcp_sse router. The main goal is to make it easier for developers to connect to a pre-hosted MCP server without requiring Docker, by surfacing the relevant server URL and API key information in the UI, and enabling the backend endpoint.

Frontend Enhancements:

Added a "Pre-hosted MCP" section to the developer settings page (developer.dart), allowing users to easily copy the MCP server URL and see instructions for using their MCP API key.
Imported the Env class to retrieve the API base URL for the MCP server endpoint.

Backend Integration:

Registered the new mcp_sse router in the backend application, making the SSE endpoint available for client connections. [1] [2]

duplicate of #3652

compatible with apps like poke.com

(thanks gemini)

dd

gemini-code-assist

Code Review

This pull request introduces a pre-hosted MCP server, which is a great feature for developers. The frontend changes in Dart look good, and the backend integration in Python is mostly solid. However, I've identified a few critical and high-severity issues in the new mcp_sse.py router that should be addressed before this can be safely deployed to production. The most critical issue is the use of in-memory session storage, which will not work correctly in a multi-worker environment. I've also found issues with incorrect JSON-RPC error handling, a security inconsistency in one of the new endpoints, and silent error handling. My review comments provide details and suggestions for fixing these.

neooriginal · 2025-12-08T14:07:00Z

This PR is ready to be merged. It was fully tested with

Poke (https://poke.com) - it could successfully interact with the MCP to tell me details about my memories aswell as tell me what OMI does.
ChatGPT (https://chatgpt.com) - same as above

(issues caught by Gemini Code review)

hugoaap-code · 2025-12-08T20:56:41Z

we need this! used poke.com with limitless pendant mcp server, it was so cool and helpful!

neooriginal · 2025-12-08T21:03:03Z

we need this! used poke.com with limitless pendant mcp server, it was so cool and helpful!

For sure! Hope it will be merged soon

aaravgarg · 2025-12-08T21:10:43Z

@gemini-code-assist review

gemini-code-assist

Code Review

This pull request successfully introduces a hosted MCP server, adding a new UI section in the developer settings for configuration and a corresponding backend router. The frontend changes in Dart appear solid and provide a good user experience for developers. The backend implementation in mcp_sse.py is comprehensive but has a few critical and high-severity issues that need to be addressed. Specifically, the session management approach is not safe for production, and error handling for invalid client input and request parsing could be improved to be more robust and informative.

gemini-code-assist · 2025-12-08T21:12:34Z

+router = APIRouter()
+
+# Store active sessions
+active_sessions: dict = {}


The use of a global dictionary active_sessions for session management is not safe for production environments. When running with multiple worker processes (e.g., using gunicorn), each worker will have its own in-memory copy of this dictionary. This will lead to session data being inconsistent across workers, causing requests to fail if they are routed to a worker that did not create the session. This is a critical issue that will break session handling under load.

To fix this, you should use a shared, persistent store for session management, such as Redis or Memcached. This will ensure that all worker processes share the same session state.

this is not necessary as there is no need for it to persist

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

neooriginal · 2025-12-09T06:19:34Z

@gemini-code-assist review

gemini-code-assist

Code Review

This pull request introduces a hosted MCP server, adding a new UI section in the developer settings for configuration details and a new backend router (mcp_sse) to handle the server logic. The frontend changes look good, providing a clear way for developers to get the necessary connection information. The backend implementation, however, has a critical issue with its session management, which uses an in-memory dictionary that is not suitable for a multi-worker production environment. Additionally, there's an inconsistency in input validation that should be addressed.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

mdmohsin7 · 2025-12-11T18:16:22Z

@neooriginal any demo video or something? Or any example mcp that I can use to test this?

neooriginal · 2025-12-11T18:21:03Z

@neooriginal any demo video or something? Or any example mcp that I can use to test this?

Can't, too much private data. You can use Chatgpt or poke or anything else

aaravgarg · 2025-12-14T03:48:08Z

what abt oauth in chatgpt, how do u handle that @neooriginal

aaravgarg · 2025-12-14T04:22:08Z

@neooriginal works with poke, pls tell how it works with chatgpt or attach a connection flow at least with chatgpt which wont reveal any data

once thats done, will merge

neooriginal · 2025-12-14T08:11:43Z

what abt oauth in chatgpt, how do u handle that @neooriginal

Just put any username like "Omi" and as oauth key the API key

neooriginal · 2025-12-14T17:36:56Z

Server URL: https://api.omi.me/v1/mcp/sse
Authentication: OAuth 2.0 Client Credentials
Client ID: omi (or any value)
Client Secret: Your MCP API key (omi_mcp_...)

Hope this helps.

aaravgarg · 2025-12-15T11:47:08Z

Error fetching OAuth configuration
MCP server https://omi-backend.ngrok.app/v1/mcp/sse does not implement OAuth

error from chatgpt

pls try once urself, idts it works

aaravgarg · 2025-12-15T12:08:03Z

@neooriginal chatgpt calls these endpoints:

INFO: 52.255.111.27:0 - "POST /v1/mcp/sse HTTP/1.1" 401 Unauthorized
INFO: 52.255.111.19:0 - "GET /.well-known/oauth-protected-resource/v1/mcp/sse HTTP/1.1" 404 Not Found
INFO: 52.255.111.19:0 - "GET /.well-known/oauth-protected-resource HTTP/1.1" 404 Not Found
INFO: 52.255.111.18:0 - "GET /.well-known/oauth-authorization-server/v1/mcp/sse HTTP/1.1" 404 Not Found
INFO: 52.255.111.18:0 - "GET /v1/mcp/sse/.well-known/oauth-authorization-server HTTP/1.1" 404 Not Found
INFO: 52.255.111.18:0 - "GET /.well-known/oauth-authorization-server HTTP/1.1" 404 Not Found
INFO: 52.255.111.18:0 - "GET /.well-known/openid-configuration/v1/mcp/sse HTTP/1.1" 404 Not Found
INFO: 52.255.111.18:0 - "GET /v1/mcp/sse/.well-known/openid-configuration HTTP/1.1" 404 Not Found
INFO: 52.255.111.18:0 - "GET /.well-known/openid-configuration HTTP/1.1" 404 Not Found
INFO: 63.124.68.69:0 - "GET /v1/mcp/sse HTTP/1.1" 401 Unauthorized
INFO: 63.124.68.69:0 - "GET /favicon.ico HTTP/1.1" 404 Not Found

neooriginal · 2025-12-15T12:35:16Z

That's weird, I did try it myself. Probably made a simple change that broke oauth.
Will fix later, sorry

compatible with apps like poke.com and chatgpt web. for apps that require this kind of format: <img width="494" height="563" alt="Bildschirmfoto 2025-12-08 um 12 27 10" src="https://github.com/user-attachments/assets/30575fc4-96df-42b1-9b14-cef09d353469" /> This pull request introduces a new "Pre-hosted MCP" section in the developer settings page and adds backend support for a new `mcp_sse` router. The main goal is to make it easier for developers to connect to a pre-hosted MCP server without requiring Docker, by surfacing the relevant server URL and API key information in the UI, and enabling the backend endpoint. **Frontend Enhancements:** * Added a "Pre-hosted MCP" section to the developer settings page (`developer.dart`), allowing users to easily copy the MCP server URL and see instructions for using their MCP API key. * Imported the `Env` class to retrieve the API base URL for the MCP server endpoint. **Backend Integration:** * Registered the new `mcp_sse` router in the backend application, making the SSE endpoint available for client connections. [[1]](diffhunk://#diff-df5184bf1f67239fcedd4578cd15b7c94f3f765feabd09c5f20b5831bca33903R27) [[2]](diffhunk://#diff-df5184bf1f67239fcedd4578cd15b7c94f3f765feabd09c5f20b5831bca33903R81) duplicate of BasedHardware#3652

neooriginal added 4 commits December 8, 2025 12:17

pre-hosted MCP

6ea39d3

compatible with apps like poke.com

clean UI of MCP URL

acb16e1

code cleanup

a4ba0e8

(thanks gemini)

Merge pull request #1 from neooriginal/main

3143731

dd

neooriginal mentioned this pull request Dec 8, 2025

pre-hosted MCP #3652

Closed

gemini-code-assist Bot reviewed Dec 8, 2025

View reviewed changes

Comment thread backend/routers/mcp_sse.py

Comment thread backend/routers/mcp_sse.py

Comment thread backend/routers/mcp_sse.py Outdated

Comment thread backend/routers/mcp_sse.py Outdated

neooriginal added 2 commits December 8, 2025 14:50

add support for OAuth MCPs

250fc51

generalize app titles

ad56aff

neooriginal requested review from aaravgarg and beastoin and removed request for aaravgarg December 8, 2025 14:07

neooriginal changed the title ~~pre-hosted MCP~~ feat: hosted MCP server Dec 8, 2025

neooriginal added 2 commits December 8, 2025 15:10

fix two MCP issues

17868a0

(issues caught by Gemini Code review)

fix: mcp error logging

9a92c5e

gemini-code-assist Bot reviewed Dec 8, 2025

View reviewed changes

neooriginal and others added 3 commits December 8, 2025 22:13

Update backend/routers/mcp_sse.py

9800bf3

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update backend/routers/mcp_sse.py

2451f08

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update backend/routers/mcp_sse.py

9d61cff

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

gemini-code-assist Bot reviewed Dec 9, 2025

View reviewed changes

Comment thread backend/routers/mcp_sse.py

Comment thread backend/routers/mcp_sse.py Outdated

Update backend/routers/mcp_sse.py

298bdda

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

aaravgarg requested review from mdmohsin7 and removed request for aaravgarg and beastoin December 9, 2025 09:56

neooriginal and others added 2 commits December 15, 2025 14:58

Update mcp_sse.py

83d85cd

rm: oauth

64aac6f

aaravgarg merged commit c3d5c1f into BasedHardware:main Dec 15, 2025

neooriginal deleted the pre-hosted-mcp branch December 15, 2025 16:16

Conversation

neooriginal commented Dec 8, 2025

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

neooriginal commented Dec 8, 2025

Uh oh!

hugoaap-code commented Dec 8, 2025

Uh oh!

neooriginal commented Dec 8, 2025

Uh oh!

aaravgarg commented Dec 8, 2025

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

neooriginal Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

neooriginal commented Dec 9, 2025

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

mdmohsin7 commented Dec 11, 2025

Uh oh!

neooriginal commented Dec 11, 2025

Uh oh!

aaravgarg commented Dec 14, 2025

Uh oh!

aaravgarg commented Dec 14, 2025

Uh oh!

neooriginal commented Dec 14, 2025

Uh oh!

neooriginal commented Dec 14, 2025

Uh oh!

aaravgarg commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aaravgarg commented Dec 15, 2025

Uh oh!

neooriginal commented Dec 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aaravgarg commented Dec 15, 2025 •

edited

Loading