Skip to content

fix: account deletion: clear cache#3666

Merged
beastoin merged 1 commit into
BasedHardware:mainfrom
neooriginal:fix-account-delete-cache
Dec 17, 2025
Merged

fix: account deletion: clear cache#3666
beastoin merged 1 commit into
BasedHardware:mainfrom
neooriginal:fix-account-delete-cache

Conversation

@neooriginal
Copy link
Copy Markdown
Collaborator

This pull request makes a small but important improvement to the account deletion flow. After a user deletes their account and signs out, it now also clears all files managed by WalFileManager to ensure more thorough cleanup of user data.

  • Account deletion flow:
    • Added a call to WalFileManager.clearAll() after signing out to clear all WAL-managed files.
    • Imported omi/utils/wal_file_manager.dart to support the new cleanup step.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a call to clear WalFileManager files during account deletion, which is a good improvement for data cleanup. However, I've identified a critical issue in the deleteAccountNow function related to error handling and an unawaited asynchronous call. An error during the deletion process could leave the app in an unresponsive state. The recommendation for a try-catch-finally block for error handling aligns with repository guidelines for operations with non-negligible failure chances. I've provided feedback on how to make this process more robust.

Comment thread app/lib/pages/settings/delete_account.dart
@beastoin beastoin merged commit 3b8462f into BasedHardware:main Dec 17, 2025
@beastoin
Copy link
Copy Markdown
Collaborator

lgtm @neooriginal

@neooriginal neooriginal deleted the fix-account-delete-cache branch December 30, 2025 03:39
Glucksberg pushed a commit to Glucksberg/omi-local that referenced this pull request Apr 28, 2026
Co-authored-by: Neotastisch <54811660+Neotastisch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants