fix: account deletion: clear cache#3666
Merged
beastoin merged 1 commit intoDec 17, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a call to clear WalFileManager files during account deletion, which is a good improvement for data cleanup. However, I've identified a critical issue in the deleteAccountNow function related to error handling and an unawaited asynchronous call. An error during the deletion process could leave the app in an unresponsive state. The recommendation for a try-catch-finally block for error handling aligns with repository guidelines for operations with non-negligible failure chances. I've provided feedback on how to make this process more robust.
Collaborator
|
lgtm @neooriginal |
Glucksberg
pushed a commit
to Glucksberg/omi-local
that referenced
this pull request
Apr 28, 2026
Co-authored-by: Neotastisch <54811660+Neotastisch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small but important improvement to the account deletion flow. After a user deletes their account and signs out, it now also clears all files managed by
WalFileManagerto ensure more thorough cleanup of user data.WalFileManager.clearAll()after signing out to clear all WAL-managed files.omi/utils/wal_file_manager.dartto support the new cleanup step.