Skip to content

Star conversation#3716

Merged
mdmohsin7 merged 9 commits into
mainfrom
star-conversation
Dec 13, 2025
Merged

Star conversation#3716
mdmohsin7 merged 9 commits into
mainfrom
star-conversation

Conversation

@aaravgarg
Copy link
Copy Markdown
Collaborator

@aaravgarg aaravgarg commented Dec 10, 2025

Functionality to star a conversation

  • star from conversation detail page
  • shows star on convo list item on homepage
  • can also be filtered by starred convos on homepage
  • also set double tap on device to star ongoing conversation

@aaravgarg aaravgarg requested a review from mdmohsin7 December 10, 2025 20:19
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a "star conversation" feature, which is implemented across the backend and the Flutter application. The changes include a new API endpoint, database model updates, and extensive UI modifications to support starring, filtering by starred, and a new double-tap action. The implementation is mostly solid, and the identified potential race condition in the Flutter UI code regarding context and setState after an async gap without checking if the widget is still mounted has been highlighted for review.

Comment thread app/lib/pages/conversation_detail/page.dart
@aaravgarg
Copy link
Copy Markdown
Collaborator Author

@gemini-code-assist review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the functionality to star conversations, including UI changes on the conversation detail page and conversation list, a new filter on the homepage, and a new double-tap action to star an ongoing conversation. The backend is updated with a new endpoint to support this. The implementation looks solid and covers all the described features. I've confirmed the identified instances where a deprecated method withOpacity() is used, which should be replaced with the custom extension method withValues() as per the repository's guidelines.

Comment thread app/lib/pages/conversation_detail/page.dart Outdated
Comment thread app/lib/pages/conversations/widgets/empty_conversations.dart Outdated
Comment thread app/lib/pages/conversations/widgets/processing_capture.dart Outdated
Comment thread app/lib/pages/conversations/widgets/search_widget.dart Outdated
Comment thread app/lib/pages/settings/device_settings.dart Outdated
aaravgarg and others added 5 commits December 10, 2025 17:58
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@mdmohsin7 mdmohsin7 merged commit 1a12c8c into main Dec 13, 2025
@mdmohsin7 mdmohsin7 deleted the star-conversation branch December 13, 2025 13:15
@hugoaap-code
Copy link
Copy Markdown
Collaborator

Limitless users will love that

@aaravgarg
Copy link
Copy Markdown
Collaborator Author

Limitless users will love that

This feature should be live on the app stores in about a day or two.

Glucksberg pushed a commit to Glucksberg/omi-local that referenced this pull request Apr 28, 2026
Functionality to star a conversation
- star from conversation detail page
- shows star on convo list item on homepage
- can also be filtered by starred convos on homepage
- also set double tap on device to star ongoing conversation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants