Revert "fix: ble write handling"

[mdmohsin7]

Reverts #3471

[gemini-code-assist]

Code Review

The pull request reverts a previous change related to BLE write handling. The original comment highlighting critical issues with the reverted BLE write functionality, including lack of long write support, writeWithoutResponse optimization, concurrency issues, and retries, has been kept as it does not contradict any existing rules and provides valuable feedback for robust BLE communication. The comment suggests re-introducing a more robust write mechanism.

[gemini-code-assist]

This revert simplifies the write logic, but it re-introduces several critical issues that the previous implementation was trying to solve:

• Lack of long write support: The call to characteristic.write(data) doesn't set allowLongWrite: true. This will cause writes larger than the MTU (typically 20 bytes) to fail on Android.
• No writeWithoutResponse optimization: The previous code would use write without response if the characteristic supported it, which improves throughput. This implementation will always use write with response, which is slower.
• Concurrency issues: Without a write queue (like the _writeQueue that was removed), concurrent calls to writeCharacteristic can lead to race conditions and GATT_BUSY errors, making the BLE communication unreliable.
• No retries: The lack of a retry mechanism for transient errors makes the connection more fragile.

While I understand the reverted code may have had issues, simply reverting it makes the BLE write functionality significantly less robust. I'd strongly recommend re-introducing a more robust write mechanism that handles these cases. At a minimum, please consider enabling long writes and using write without response where appropriate.

      await characteristic.write(
        data,
        withoutResponse: characteristic.properties.writeWithoutResponse,
        allowLongWrite: true,
      );