Skip to content

feat: improve date time picker ux for scheduling#3769

Merged
beastoin merged 3 commits into
BasedHardware:mainfrom
khangkontum:feat/improve-date-time-picker
Dec 15, 2025
Merged

feat: improve date time picker ux for scheduling#3769
beastoin merged 3 commits into
BasedHardware:mainfrom
khangkontum:feat/improve-date-time-picker

Conversation

@khangkontum
Copy link
Copy Markdown
Contributor

@khangkontum khangkontum commented Dec 14, 2025

image image image

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the date and time picker functionality within the ActionItemFormSheet by replacing the custom date navigation and CupertinoDatePicker with the calendar_date_picker2 package for date selection and a standard showTimePicker for time. The changes include adding new package dependencies, updating various UI colors to use ResponsiveHelper constants, and enhancing the _formatDueDateWithTime method to conditionally display the year. A review comment points out that DateTime.now() is called multiple times within the CalendarDatePicker2 configuration, recommending it be called once and stored in a variable to ensure consistency, especially when the code runs near midnight.

Comment thread app/lib/pages/action_items/widgets/action_item_form_sheet.dart Outdated
@beastoin beastoin merged commit e3b33ce into BasedHardware:main Dec 15, 2025
@beastoin
Copy link
Copy Markdown
Collaborator

lgtm @khangkontum

@khangkontum khangkontum deleted the feat/improve-date-time-picker branch December 15, 2025 08:46
Glucksberg pushed a commit to Glucksberg/omi-local that referenced this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants