Shorten share message for app details#3780
Conversation
it's cleaner
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to shorten the share message for app details. While the intention to create a cleaner share message is good, the current implementation removes crucial context like the app's name, author, and description. This can lead to a poor user experience on platforms that don't support link previews, where a recipient would only see a raw URL. I've added a comment suggesting we restore the contextual information to ensure the shared message is always informative for the recipient.
| if (app.isNotPersona()) { | ||
| Share.share( | ||
| 'Check out this app on Omi AI: ${app.name} by ${app.author} \n\n${app.description.decodeString}\n\n\nhttps://h.omi.me/apps/${app.id}', | ||
| 'https://h.omi.me/apps/${app.id}', |
There was a problem hiding this comment.
Shortening the share message to only the URL can result in a poor user experience for the recipient. Many platforms or apps (like SMS) do not generate link previews, so the recipient would only see a raw URL without any context about what is being shared. The previous message provided important context like the app name, author, and description. It's recommended to restore this context to ensure the shared message is always informative.
| 'https://h.omi.me/apps/${app.id}', | |
| 'Check out this app on Omi AI: ${app.name} by ${app.author} \n\n${app.description.decodeString}\n\n\nhttps://h.omi.me/apps/${app.id}', |
|
lgtm @kodjima33 btw next time with ui changes, feel free to merge after thoroughly testing. you just need to create a pr like this so we can track. |
3 participants
it's cleaner