embed watch app if building for iphone#3803
Conversation
There was a problem hiding this comment.
Code Review
This pull request correctly configures the Xcode project to embed the omiWatchApp for iPhone builds, which is the standard procedure for shipping a companion watch application. However, the changes appear to have been made with an older version of Xcode, resulting in a downgrade of the project file's objectVersion from 77 to 54. This is a critical issue that can lead to build failures, loss of project settings, and compatibility problems for other team members. My review includes a critical comment to revert this version downgrade and regenerate the changes with a consistent Xcode version.
| classes = { | ||
| }; | ||
| objectVersion = 77; | ||
| objectVersion = 54; |
There was a problem hiding this comment.
The objectVersion of the Xcode project has been downgraded from 77 to 54. This typically occurs when the project is saved with an older version of Xcode and can lead to serious compatibility issues, loss of project settings, and frequent merge conflicts for the team. It's critical to use a consistent Xcode version for project modifications. Please regenerate these changes using the team's standard Xcode version to ensure the project file remains compatible and stable.
objectVersion = 77;
No description provided.