Skip to content

embed watch app if building for iphone#3803

Merged
mdmohsin7 merged 1 commit into
mainfrom
conditional-embed
Dec 16, 2025
Merged

embed watch app if building for iphone#3803
mdmohsin7 merged 1 commit into
mainfrom
conditional-embed

Conversation

@mdmohsin7
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly configures the Xcode project to embed the omiWatchApp for iPhone builds, which is the standard procedure for shipping a companion watch application. However, the changes appear to have been made with an older version of Xcode, resulting in a downgrade of the project file's objectVersion from 77 to 54. This is a critical issue that can lead to build failures, loss of project settings, and compatibility problems for other team members. My review includes a critical comment to revert this version downgrade and regenerate the changes with a consistent Xcode version.

classes = {
};
objectVersion = 77;
objectVersion = 54;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The objectVersion of the Xcode project has been downgraded from 77 to 54. This typically occurs when the project is saved with an older version of Xcode and can lead to serious compatibility issues, loss of project settings, and frequent merge conflicts for the team. It's critical to use a consistent Xcode version for project modifications. Please regenerate these changes using the team's standard Xcode version to ensure the project file remains compatible and stable.

    objectVersion = 77;

@mdmohsin7 mdmohsin7 merged commit 400e161 into main Dec 16, 2025
1 check passed
@mdmohsin7 mdmohsin7 deleted the conditional-embed branch December 16, 2025 18:36
Glucksberg pushed a commit to Glucksberg/omi-local that referenced this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant