Skip to content

feat: web proactive-notifications#4435

Closed
neooriginal wants to merge 7 commits intoBasedHardware:mainfrom
neooriginal:web-proactive-assistant
Closed

feat: web proactive-notifications#4435
neooriginal wants to merge 7 commits intoBasedHardware:mainfrom
neooriginal:web-proactive-assistant

Conversation

@neooriginal
Copy link
Copy Markdown
Collaborator

Added proactive notification logic from the macos app to the web app. See below for technical details.

image image image image

This pull request introduces a new "Proactive Assistant" feature to the application, providing infrastructure for proactive notifications and monitoring using Gemini AI. The changes include environment variable setup, context management, UI components, and integration into the main layout and sidebar.

Proactive Assistant Feature Implementation:

  • Added a new context and provider (ProactiveContext, ProactiveProvider) to manage proactive assistant state, settings (including advice and focus assistants), and history, with localStorage persistence and legacy support.
  • Implemented a proactive monitoring widget (ProactiveMonitoringWidget) for user interaction, status display, error handling, and quick access to settings.
  • Integrated the proactive provider and widget into the main application layout, ensuring the feature is available throughout the app. [1] [2] [3]
  • Added a new "Proactive Assistant" entry to the sidebar menu with an appropriate icon for easy navigation. [1] [2]

Gemini API Integration:

  • Added a server action (analyzeScreenAction) to interact with the Gemini API for analyzing screen content, supporting image and prompt input, error handling, and extensibility for different models and response schemas.

Configuration and Environment:

  • Updated the example environment configuration file (env.local.example) to include required keys for Firebase, Gemini API, push notifications, and analytics, supporting the new proactive assistant and notification features.

gemini-code-assist[bot]

This comment was marked as outdated.

neooriginal and others added 3 commits January 28, 2026 19:51
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@neooriginal
Copy link
Copy Markdown
Collaborator Author

@gemini-code-assist re-review pls

gemini-code-assist[bot]

This comment was marked as outdated.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@neooriginal
Copy link
Copy Markdown
Collaborator Author

@gemini-code-assist re-review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a significant new feature, the Proactive Assistant, by porting logic from the macOS app. The implementation is well-structured, with clear separation of concerns between server actions for Gemini API calls, context providers for state management, and React components for the UI. The use of a dedicated hook useProactiveNotifications to encapsulate the core logic is a great pattern.

I've identified two high-severity issues that should be addressed:

  1. A security vulnerability where the Gemini API key is exposed in the URL.
  2. A bug in the proactive settings widget UI that makes it non-functional.

Details and suggestions for fixes are in the review comments. Besides these points, the code is clean and the feature seems well-integrated into the existing application.

Comment thread web/app/src/app/actions/proactive.ts
Comment thread web/app/src/components/proactive/ProactiveSettings.tsx
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@neooriginal
Copy link
Copy Markdown
Collaborator Author

ready to be merged

@neooriginal neooriginal requested a review from aaravgarg January 29, 2026 08:27
@beastoin
Copy link
Copy Markdown
Collaborator

beastoin commented Feb 6, 2026

@smian1 ❤️

@aaravgarg aaravgarg requested review from smian1 and removed request for aaravgarg February 6, 2026 07:43
@beastoin
Copy link
Copy Markdown
Collaborator

Hey @neooriginal, merging this — thanks for the work.

Honest note: I don't have any plans to actively maintain the web version right now. I know that's tough to hear, but I don't want to waste the community's energy on reviews that go nowhere. So I'm merging these.

As a next step, it would be great if you could talk to the team about taking ownership of the Omi web version maintenance. Would love to see it move forward with a proper maintainer behind it.

@beastoin
Copy link
Copy Markdown
Collaborator

@neooriginal This one has merge conflicts — could you rebase/resolve them? Will merge once it's clean.

@neooriginal
Copy link
Copy Markdown
Collaborator Author

On it

neooriginal added a commit that referenced this pull request Feb 17, 2026
- Add proactive monitoring widget and settings
- Add Gemini API client for screen analysis
- Add focus analysis and proactive analysis libs
- Add screen capture utilities
- Integrate proactive assistant in recording UI
- Add settings section for proactive configuration

Cherry-picked from PR #4435 with merge conflicts resolved.
@neooriginal
Copy link
Copy Markdown
Collaborator Author

@thinhx ready in #4845

@github-actions
Copy link
Copy Markdown
Contributor

Hey @neooriginal 👋

Thank you so much for taking the time to contribute to Omi! We truly appreciate you putting in the effort to submit this pull request.

After careful review, we've decided not to merge this particular PR. Please don't take this personally — we genuinely try to merge as many contributions as possible, but sometimes we have to make tough calls based on:

  • Project standards — Ensuring consistency across the codebase
  • User needs — Making sure changes align with what our users need
  • Code best practices — Maintaining code quality and maintainability
  • Project direction — Keeping aligned with our roadmap and vision

Your contribution is still valuable to us, and we'd love to see you contribute again in the future! If you'd like feedback on how to improve this PR or want to discuss alternative approaches, please don't hesitate to reach out.

Thank you for being part of the Omi community! 💜

@neooriginal neooriginal deleted the web-proactive-assistant branch February 17, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants