Replace dashboard score cards with task lists#5647
Conversation
Greptile SummaryThis PR simplifies both the mobile (Flutter) and macOS (SwiftUI) dashboards by removing the daily score card widgets and consolidating the task list display.
Confidence Score: 4/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
subgraph Before["Before (3-row grid)"]
B_R1["Row 1: ScoreWidget | GoalsWidget"]
B_R2["Row 2: ConversationsWidget | ActivitiesWidget"]
B_R3["Row 3: TasksWidget (full width)"]
B_R1 --> B_R2 --> B_R3
end
subgraph After["After (1-row grid)"]
A_R1["Row 1: TasksWidget | GoalsWidget"]
A_R2["Conversations embedded below"]
A_R1 --> A_R2
end
Before -- "PR #5647" --> After
|
| void _refreshGoals() { | ||
| _dailyScoreWidgetKey.currentState?.reloadGoals(); | ||
| } | ||
| void _refreshGoals() {} |
There was a problem hiding this comment.
Dead no-op method left behind
_refreshGoals() is now an empty body (no-op) but is still called on pull-to-refresh (line 168) and passed as a callback to GoalsWidget (line 218). Previously it delegated to DailyScoreWidget.reloadGoals(), which no longer exists.
Since the method does nothing, consider removing it entirely along with its call sites to avoid confusion. The GoalsWidget.onRefresh callback invokes this no-op on every goal refresh, which is harmless but misleading.
| void _refreshGoals() {} | |
| void _refreshGoals() {} |
## Summary - replace the macOS dashboard score card with the existing tasks list widget and remove the duplicate tasks row - remove the mobile conversations dashboard daily score card and keep the existing tasks list section ## Verification - `cd app && flutter test test/providers test/widgets test/unit` passed in the main workspace where local generated Firebase/env files exist - `cd desktop/Desktop && swift build` passed in the main workspace - `cd desktop/Desktop && swift test` ends with `no tests found` for this package - direct launch of the built macOS binary for UI automation is blocked in this environment because launching the raw SwiftPM executable is not a bundled app and `UNUserNotificationCenter.current()` asserts at startup - fresh clean-worktree Flutter test run is blocked by missing generated local files (`firebase_options_*.dart`, `dev_env.g.dart`, `prod_env.g.dart`) that are not present in a clean checkout on this machine
Summary
Verification
cd app && flutter test test/providers test/widgets test/unitpassed in the main workspace where local generated Firebase/env files existcd desktop/Desktop && swift buildpassed in the main workspacecd desktop/Desktop && swift testends withno tests foundfor this packageUNUserNotificationCenter.current()asserts at startupfirebase_options_*.dart,dev_env.g.dart,prod_env.g.dart) that are not present in a clean checkout on this machine