Revert "fix: replace fixed 15s WebSocket reconnect with exponential backoff + jitter"#5712
Revert "fix: replace fixed 15s WebSocket reconnect with exponential backoff + jitter"#5712
Conversation
…ackoff +…" This reverts commit fa95dcf.
|
Hey @beastoin 👋 Thank you so much for taking the time to contribute to Omi! We truly appreciate you putting in the effort to submit this pull request. After careful review, we've decided not to merge this particular PR. Please don't take this personally — we genuinely try to merge as many contributions as possible, but sometimes we have to make tough calls based on:
Your contribution is still valuable to us, and we'd love to see you contribute again in the future! If you'd like feedback on how to improve this PR or want to discuss alternative approaches, please don't hesitate to reach out. Thank you for being part of the Omi community! 💜 |
Greptile SummaryThis PR reverts #5617, which replaced the fixed 15-second
The revert is clean — no leftover references to the removed fields or methods. The original 15s fixed-interval reconnect may cause synchronized reconnect storms under high concurrency (the problem #5617 aimed to solve), but this is a deliberate rollback likely due to regressions introduced by the backoff logic. Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant WS as WebSocket
participant CP as CaptureProvider
participant Timer as Timer.periodic(15s)
WS->>CP: onClosed() / onError()
CP->>Timer: _startKeepAliveServices()
loop Every 15 seconds
Timer->>CP: Check rate limit (1/15s)
alt Socket connected or device not ready
CP->>Timer: t.cancel()
else User not signed in
CP->>Timer: t.cancel()
else Device available
CP->>WS: _initiateWebsocket()
end
end
WS->>CP: onConnected()
CP->>CP: _transcriptServiceReady = true
Last reviewed commit: 8ed4791 |
Reverts #5617