Revert WebSocket reconnect exponential backoff (#5617)#5713
Revert WebSocket reconnect exponential backoff (#5617)#5713
Conversation
Greptile SummaryThis PR reverts #5617, which introduced exponential backoff + jitter for WebSocket reconnection in
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant WS as WebSocket
participant CP as CaptureProvider
participant Timer as Timer.periodic(15s)
WS->>CP: onClosed() / onError()
CP->>Timer: _startKeepAliveServices()
loop Every 15 seconds
Timer->>CP: Check rate limit
alt Rate limited
CP-->>Timer: Skip (< 15s since last)
else Socket connected or device not ready
CP->>Timer: t.cancel()
else Not signed in
CP->>Timer: t.cancel()
else Device available
CP->>WS: _initiateWebsocket()
WS-->>CP: onConnected()
end
end
Last reviewed commit: 7b433d5 |
|
Hey @beastoin 👋 Thank you so much for taking the time to contribute to Omi! We truly appreciate you putting in the effort to submit this pull request. After careful review, we've decided not to merge this particular PR. Please don't take this personally — we genuinely try to merge as many contributions as possible, but sometimes we have to make tough calls based on:
Your contribution is still valuable to us, and we'd love to see you contribute again in the future! If you'd like feedback on how to improve this PR or want to discuss alternative approaches, please don't hesitate to reach out. Thank you for being part of the Omi community! 💜 |
Reverts #5617 per CTO request.
This PR added exponential backoff + jitter for WebSocket reconnection (replacing fixed 15s interval). It introduced
min(),pow(), andRandom()calls without importingdart:math, which broke the Codemagic build after the related #5618 revert removed the import. The reconnection logic change also affects the core audio capture flow and needs proper testing before re-merging.by AI for @beastoin