Update onboarding voice shortcut example question#5749
Merged
Conversation
Contributor
Greptile SummaryThis PR is a copy-only change to the macOS desktop onboarding flow, replacing a generic weather example question with
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant OnboardingVoiceShortcutStepView
participant PushToTalkManager
participant FloatingControlBarManager
User->>OnboardingVoiceShortcutStepView: View appears (onAppear)
OnboardingVoiceShortcutStepView->>FloatingControlBarManager: setup(appState, chatProvider)
FloatingControlBarManager-->>OnboardingVoiceShortcutStepView: barState
OnboardingVoiceShortcutStepView->>PushToTalkManager: setup(barState)
Note over OnboardingVoiceShortcutStepView: Shows hint: "Try asking: What's on my screen?"
User->>PushToTalkManager: Hold shortcut key
PushToTalkManager-->>OnboardingVoiceShortcutStepView: state = .listening
OnboardingVoiceShortcutStepView->>OnboardingVoiceShortcutStepView: observedShortcutPress = true
User->>PushToTalkManager: Release shortcut key
PushToTalkManager-->>OnboardingVoiceShortcutStepView: state = .idle (after finalizing)
OnboardingVoiceShortcutStepView->>OnboardingVoiceShortcutStepView: showContinue = true (hint hidden, Continue button shown)
User->>OnboardingVoiceShortcutStepView: Tap "Continue"
OnboardingVoiceShortcutStepView->>OnboardingVoiceShortcutStepView: onComplete()
Last reviewed commit: 35865fd |
Glucksberg
pushed a commit
to Glucksberg/omi-local
that referenced
this pull request
Apr 28, 2026
## Summary - replace the generic/weather example in the merged voice shortcut onboarding step - tell users to try asking "What's on my screen?" instead ## Verification - xcrun swift build -c debug --package-path /private/tmp/omi-onboarding-audio-copy/desktop/Desktop - source diff confirmed the onboarding copy now references "What's on my screen?" ## Note - a fast binary swap into the older ad-hoc Omi Audio bundle failed because that local bundle has stale framework layout; this change is copy-only and compiled cleanly from the fresh worktree
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Note