Skip to content

Update onboarding voice shortcut example question#5749

Merged
kodjima33 merged 1 commit intomainfrom
codex/macos-onboarding-audio-copy
Mar 17, 2026
Merged

Update onboarding voice shortcut example question#5749
kodjima33 merged 1 commit intomainfrom
codex/macos-onboarding-audio-copy

Conversation

@kodjima33
Copy link
Copy Markdown
Collaborator

Summary

  • replace the generic/weather example in the merged voice shortcut onboarding step
  • tell users to try asking "What's on my screen?" instead

Verification

  • xcrun swift build -c debug --package-path /private/tmp/omi-onboarding-audio-copy/desktop/Desktop
  • source diff confirmed the onboarding copy now references "What's on my screen?"

Note

  • a fast binary swap into the older ad-hoc Omi Audio bundle failed because that local bundle has stale framework layout; this change is copy-only and compiled cleanly from the fresh worktree

@kodjima33 kodjima33 merged commit 7ae1abc into main Mar 17, 2026
1 check passed
@kodjima33 kodjima33 deleted the codex/macos-onboarding-audio-copy branch March 17, 2026 17:13
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Mar 17, 2026

Greptile Summary

This PR is a copy-only change to the macOS desktop onboarding flow, replacing a generic weather example question with "What's on my screen?" to better showcase the screen-awareness feature during the voice shortcut setup step. No logic, layout, or behavioral changes are introduced.

  • Updates the left-pane instructional paragraph to embed "What's on my screen?" as a concrete example of what to ask while holding the shortcut key
  • Replaces the right-pane hint text "Try asking: \"What's the weather in my city?\"" with "Try asking: \"What's on my screen?\""
  • Both panes now consistently reference the same example question, which is a stronger demonstration of a platform-specific capability than the previous weather query
  • No localization strings or l10n keys are used in this file (raw Text(...) literals throughout), which is consistent with the rest of the file and the existing pattern — no regression introduced here

Confidence Score: 5/5

  • This PR is safe to merge — it is a pure UI copy change with no logic, state, or behavioral impact.
  • Only two string literals are changed in a single Swift UI file. No logic, layout, state management, or external integrations are touched. The change compiled cleanly per the PR author's verification, and the new copy is contextually appropriate for a screen-awareness feature demo.
  • No files require special attention.

Important Files Changed

Filename Overview
desktop/Desktop/Sources/OnboardingVoiceShortcutStepView.swift Copy-only change: replaces the generic "speak" instruction and "What's the weather in my city?" example with "What's on my screen?" in both the left-pane description and the right-pane hint text. No logic changes.

Sequence Diagram

sequenceDiagram
    participant User
    participant OnboardingVoiceShortcutStepView
    participant PushToTalkManager
    participant FloatingControlBarManager

    User->>OnboardingVoiceShortcutStepView: View appears (onAppear)
    OnboardingVoiceShortcutStepView->>FloatingControlBarManager: setup(appState, chatProvider)
    FloatingControlBarManager-->>OnboardingVoiceShortcutStepView: barState
    OnboardingVoiceShortcutStepView->>PushToTalkManager: setup(barState)

    Note over OnboardingVoiceShortcutStepView: Shows hint: "Try asking: What's on my screen?"

    User->>PushToTalkManager: Hold shortcut key
    PushToTalkManager-->>OnboardingVoiceShortcutStepView: state = .listening
    OnboardingVoiceShortcutStepView->>OnboardingVoiceShortcutStepView: observedShortcutPress = true

    User->>PushToTalkManager: Release shortcut key
    PushToTalkManager-->>OnboardingVoiceShortcutStepView: state = .idle (after finalizing)
    OnboardingVoiceShortcutStepView->>OnboardingVoiceShortcutStepView: showContinue = true (hint hidden, Continue button shown)

    User->>OnboardingVoiceShortcutStepView: Tap "Continue"
    OnboardingVoiceShortcutStepView->>OnboardingVoiceShortcutStepView: onComplete()
Loading

Last reviewed commit: 35865fd

Glucksberg pushed a commit to Glucksberg/omi-local that referenced this pull request Apr 28, 2026
## Summary
- replace the generic/weather example in the merged voice shortcut
onboarding step
- tell users to try asking "What's on my screen?" instead

## Verification
- xcrun swift build -c debug --package-path
/private/tmp/omi-onboarding-audio-copy/desktop/Desktop
- source diff confirmed the onboarding copy now references "What's on my
screen?"

## Note
- a fast binary swap into the older ad-hoc Omi Audio bundle failed
because that local bundle has stale framework layout; this change is
copy-only and compiled cleanly from the fresh worktree
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant