Skip to content

Add Full Disk Access guide image to onboarding#5771

Merged
kodjima33 merged 1 commit intomainfrom
feature/fda-permission-image
Mar 18, 2026
Merged

Add Full Disk Access guide image to onboarding#5771
kodjima33 merged 1 commit intomainfrom
feature/fda-permission-image

Conversation

@kodjima33
Copy link
Copy Markdown
Collaborator

Summary

  • Add full_disk_access.png guide image to Resources
  • Map "Grant Full Disk Access" button to show the guide image
  • Add full_disk_access case to OnboardingPermissionImage

🤖 Generated with Claude Code

Shows a visual guide when the AI asks the user to grant Full Disk Access,
same pattern as other permission images (screen recording, microphone, etc).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@kodjima33 kodjima33 merged commit 5a8a04b into main Mar 18, 2026
1 check passed
@kodjima33 kodjima33 deleted the feature/fda-permission-image branch March 18, 2026 02:46
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Mar 18, 2026

Greptile Summary

This PR completes the onboarding guide image coverage for the "Full Disk Access" macOS permission by adding a full_disk_access.png resource image, mapping the "Grant Full Disk Access" (and "Grant Disk Access") button labels to the full_disk_access permission type, and adding the corresponding case to OnboardingPermissionImage. The permission type itself (full_disk_access) was already fully wired into ChatToolExecutor, ChatPrompts, and the permission-status polling logic — this change closes the gap where the guide image was missing.

Key changes:

  • Added full_disk_access.png to desktop/Desktop/Sources/Resources/ alongside existing permission guide images
  • Mapped "full disk access" and "disk access" button label suffixes to "full_disk_access" in permissionType(from:)
  • Added case "full_disk_access" to OnboardingPermissionImage.resourceInfo returning the new PNG asset

Confidence Score: 5/5

  • This PR is safe to merge — it is a small, additive change that follows existing patterns exactly.
  • The change is minimal: one new image asset and two small additions to an existing switch/dictionary in Swift. The full_disk_access permission type was already fully supported throughout the codebase (ChatToolExecutor, ChatPrompts, AppState, permission polling) — this only adds the previously missing guide image display. No logic changes, no regressions possible.
  • No files require special attention.

Important Files Changed

Filename Overview
desktop/Desktop/Sources/OnboardingChatView.swift Adds two entries to the permission button label mapping and one case to OnboardingPermissionImage; changes are minimal, consistent with existing patterns, and integrate cleanly with existing full_disk_access handling throughout the file.
desktop/Desktop/Sources/Resources/full_disk_access.png New binary PNG asset added to the Resources directory alongside existing permission guide images (folder_access.png, microphone-settings.png, etc.); filename matches the resource name referenced in code.

Sequence Diagram

sequenceDiagram
    participant AI as AI / ChatProvider
    participant View as OnboardingChatView
    participant Image as OnboardingPermissionImage
    participant Exec as ChatToolExecutor
    participant OS as macOS System Settings

    AI->>View: quickReplyOptions = ["Grant Full Disk Access"]
    View->>Image: permissionType("Grant Full Disk Access") → "full_disk_access"
    Image-->>View: full_disk_access.png (guide image displayed)
    View->>View: User taps "Grant Full Disk Access"
    View->>Exec: request_permission(type: "full_disk_access")
    Exec->>OS: NSWorkspace.open(Privacy_AllFiles URL)
    OS-->>View: (pending — user toggles in System Settings)
    View->>View: 1s timer detects hasFullDiskAccess = true
    View->>AI: "Grant Full Disk Access — done!"
Loading

Last reviewed commit: "Add Full Disk Access..."

Glucksberg pushed a commit to Glucksberg/omi-local that referenced this pull request Apr 28, 2026
## Summary
- Add `full_disk_access.png` guide image to Resources
- Map "Grant Full Disk Access" button to show the guide image
- Add `full_disk_access` case to `OnboardingPermissionImage`

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant